-
Notifications
You must be signed in to change notification settings - Fork 25
Fix project travis and tox builds #10
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Following the accepted PRs, I propose this PR that basically fix the build issues with this project by fixing the tox.ini file to properly work with `pipenv`.
@elgertam As you can see on my personal Travis build https://travis-ci.com/AlmogCohen/cookiecutter-pipenv/builds/98225790 This PR would fix the build for this project by using changes I've already proposed in other PRs. What I did here is to fix the pytest command run |
Wait a moment, it is still broken for some reason. Maybe the Pipfile.lock |
Travis build passes for this branch...which is nice to prove a point https://travis-ci.com/AlmogCohen/cookiecutter-pipenv. Ready for a merge |
@@ -2,6 +2,12 @@ | |||
Cookiecutter Python Package Template with Pipenv | |||
================================================ | |||
|
|||
|travis| | |||
|
|||
.. |travis| image:: https://travis-ci.com/elgertam/cookiecutter-pipenv.svg?branch=master |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Now we just need the owner of the repo to enable builds on travis
;) next step we could fix the PyPi deployment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
no pressure though
Pypy3.5 break the travis build at the moment as pipenv does not officially support For now, I'll simply drop the |
@elgertam bump... I'll just point out that the travis build of this exact branch is passing successfully on my fork https://travis-ci.com/AlmogCohen/cookiecutter-pipenv so not sure if local testing is necessary. I do respect your decision on that :) |
done |
Following the accepted PRs, I propose this PR that basically fix the build issues with this project by fixing the tox.ini file to properly work with
pipenv
.