Skip to content

Proxy Emulation class in RegenerateProductUrl#79

Merged
peterjaap merged 1 commit into
elgentos:masterfrom
hostep:fixes-issue-76
Dec 28, 2023
Merged

Proxy Emulation class in RegenerateProductUrl#79
peterjaap merged 1 commit into
elgentos:masterfrom
hostep:fixes-issue-76

Conversation

@hostep

@hostep hostep commented Dec 28, 2023

Copy link
Copy Markdown
Contributor

Introduced another proxy in a constructor to avoid database access through bin/magento

This class isn't directly used in the Command classes, but the waterfall of constructors that get called eventually end up with this class.

Together with #78, this should fully fix #76

Tested on Magento 2.4.6-p3 (with magento/magento2#37424 as patch applied) and on the 2.4-develop branch of magento/magento2 github repo.

@what-the-diff

what-the-diff Bot commented Dec 28, 2023

Copy link
Copy Markdown

PR Summary

  • Dependency Update in RegenerateProductUrl.php
    The update in this file modifies the original dependency ProductUrlRewriteGenerator to a proxied version of the dependency. This action improves the efficiency of the code, as the proxy class allows lazy loading (an enhanced way of loading resources), which could potentially speed up processes and reduce memory consumption.

@peterjaap

Copy link
Copy Markdown
Collaborator

Thanks!

released; https://github.com/elgentos/magento2-regenerate-catalog-urls/releases/tag/0.3.7

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Emulation dependency injected in the console commands through DI, tries to connect to database

2 participants