Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add French translations #5

Merged
merged 5 commits into from
Dec 21, 2020
Merged

Add French translations #5

merged 5 commits into from
Dec 21, 2020

Conversation

dar5hak
Copy link
Contributor

@dar5hak dar5hak commented Dec 20, 2020

Yo @NathanBnm, I've written this new app and the strings are now stable for the 1.0.0 release. I'm going to submit it to AppCenter in a couple of days. Do you want to get the French translations in for the launch?

When you have the time, feel free to push to this branch. I have granted you write access. Cheers! ✌️

@dar5hak dar5hak added the enhancement New feature or request label Dec 20, 2020
@dar5hak
Copy link
Contributor Author

dar5hak commented Dec 20, 2020

I synchronized this branch with the meson changes. Now it's ready for translation.

@NathanBnm
Copy link
Collaborator

@dar5hak ready for review 👍

Copy link
Contributor Author

@dar5hak dar5hak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks perfect; just one doubt about the placeholder.

@dar5hak
Copy link
Contributor Author

dar5hak commented Dec 21, 2020

Actually, I'll just merge it.

@dar5hak dar5hak merged commit 4a0b227 into main Dec 21, 2020
@dar5hak dar5hak deleted the french branch January 1, 2021 12:58
@dar5hak
Copy link
Contributor Author

dar5hak commented Jan 1, 2021

Um, AppCenter release is blocked due to elementary/houston#799. It'll be a while before it's up.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants