Use dequeue rather than deregister to prevent Query Monitor Errors

[mrwweb]

With WP2Static installed, Query Monitor shows an error on every page "Missing: wp-embed". This is because that script is deregistered but not dequeued.

Changing that linked line from wp_deregister_script() to wp_dequeue_script() resolved the error (and I believe is the correct way to do what is intended).

Relevant support thread.

[leonstafford]

Great, thanks @mrwweb! Will fix!

[leonstafford]

@mrwweb I didn't dive deep enough in to check what each of those functions look like, but saw enough examples of developers calling both, so went with that for now. Please let me know if persists with latest code.

Could you please let me know a bit more of your test environment? ie Theme/plugins in use? I wasn't able to get Query Monitor showing me that error on a vanilla WP test site...

[mrwweb]

@leonstafford Sorry I didn't get back to you sooner. I poked around at this a bit and I'm not quite sure what you're running into. I've got a site running nothing but Query Monitor and wp2static with Twenty Twenty as the active theme and I'm still getting the error displayed in Query Monitor. I wish I had something better to tell you!

[leonstafford]

@mrwweb - to confirm, you're still seeing it with the latest changes in develop branch?

e88b0b6

fixes #793 dequeue when deregistering scripts

If still seeing it, please share me some more info about your WP hosting setup and I can try to reproduce

[mrwweb]

@leonstafford Sorry for not being clearer! The fix definitely works, but I couldn't figure out why you couldn't reproduce the issue for yourself before that.

[leonstafford]

@mrwweb ah, all good then! Probably just the environment I was using (https://lokl.dev). In case you try it and find WP Debug not working as usual, happy to fix it