Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use dark style in greeter session #499

Draft
wants to merge 3 commits into
base: master
Choose a base branch
from

Conversation

lenemter
Copy link
Member

@lenemter lenemter commented Sep 2, 2023

Complementary to elementary/greeter#684

@lenemter lenemter marked this pull request as ready for review January 27, 2024 12:06
@lenemter lenemter requested a review from a team January 27, 2024 12:06
@lenemter lenemter added the Status: Blocked Something else needs to be done before this can be fixed label Jan 30, 2024
Copy link
Member

@davidmhewitt davidmhewitt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This probably isn't going to work in the expected way, or at all.

The Granite.Settings object first queries the Portal, which probably isn't running in the greeter. Then it queries AccountsService, which is running, but Granite queries using the current user (which is lightdm in the greeter session).

There's also a chance of hangs here because a lot of these DBus calls happen synchronously.

I would suggest that instead of this, the Greeter needs to communicate the dark style preference to the panel, rather than the panel process trying to detect it itself in the Greeter.

@lenemter
Copy link
Member Author

lenemter commented Jan 31, 2024

@davidmhewitt elementary/greeter#684 both launches portals in the greeter session and syncs dark style preference from selected user's AccountsService to lightdm's one.

@lenemter lenemter marked this pull request as draft August 12, 2024 03:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Status: Blocked Something else needs to be done before this can be fixed
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants