Use GLib.MenuModel for context menu #769
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
danirabbit
requested changes
Aug 6, 2024
src/Widgets/TerminalWidget.vala
Outdated
Comment on lines
470
to
471
| context_popover.show_all (); | ||
| context_popover.popup (); |
There was a problem hiding this comment.
I think show_all and popup are redundant here. I'm not sure show_all is necessary when using a menu from a model
There was a problem hiding this comment.
It does not work in Gtk3 without these. Revisit in Gtk4
* Use Gtk.Menu * section labels are nullable
danirabbit
approved these changes
Aug 9, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is similar to #751 but based on latest master and more closely following current code to reduce diff (a little). Code cleanup can be done in separate PR.
Also added custom "accel" menu attribute to the items. This does not seem to be working with the current version - maybe it ill work in Gtk4?