Reboot to Firmware Setup #253
Merged
+78
−0
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
danirabbit
requested changes
Oct 31, 2022
|
I can confirm the feature works as expected, so happy to approve after the above is resolved :) |
Co-authored-by: Danielle Foré <[email protected]>
|
@danirabbit thank you very much for your feedback! I hope that I addressed all issues.
I was not sure if there is already an established way of handling dialogs as preparation for porting to Gtk4. Also feel free to improve the error dialog texts. |
|
@meisenzahl made a branch here :) #254 |
danirabbit
approved these changes
Nov 1, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If I ever need to make changes on the firmware (BIOS/UEFI) of my device, I often don't know which key combination to press when starting the device to get there. Windows offers an option to boot directly into BIOS/UEFI. On Linux, I have used https://www.freedesktop.org/software/systemd/man/systemctl.html#--firmware-setup for this so far. This feature adds a button that reboots the device and starts the BIOS/UEFI.