-
-
Notifications
You must be signed in to change notification settings - Fork 6
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Play different sound when notification is urgent #85
Play different sound when notification is urgent #85
Conversation
@marbetschar, @danrabbit and @cassidyjames I would appreciate your feedback |
@meisenzahl your PR does not play a sound at all on my end for URGENT notifications - but it does for regular ones. Is this the intended behaviour? Tested it on elementary Daily (Pre-Release of Odin) using Time Limit which sends a notification with |
@marbetschar I'm sorry I forgot to mention that this feature only works in combination with elementary/sound-theme#11 🙈 elementary/sound-theme#11 provides a new sound for urgent notifications. |
@meisenzahl installed your |
@marbetschar thanks for testing it again. I just created a demo application to make testing easier. Please give this a try. |
@meisenzahl thanks, but unfortunately still no success. Neither for Time Limit nor for the new notifications demo application. For both cases I can't hear any sound for the notification priority "URGENT". For all other priorities, the default sound is still played. Even a reboot did not help. Also, I double checked and the file Maybe @danrabbit can help out? |
926a611
to
0229f10
Compare
@marbetschar after a long time I tried it again after a new installation. Here it works. Does it work for you now? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Works for me, so its a 👍 from my end. Maybe someone from @elementary/ux wants review this as well before we merge it.
Related to #75
Works in conjunction with elementary/sound-theme#11
Test with
io.elementary.notifications.demo
and set Priority to Urgent.