-
-
Notifications
You must be signed in to change notification settings - Fork 6
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Replace Confirmations #206
base: master
Are you sure you want to change the base?
Conversation
We need to change the confirmation types of gala, sound indicator and power indicator.
|
@Marukesu I tried to use setter. Can you check please if that's what you had in mind? |
this is broken because ShowOSD doesn't have anything that can be thought as "type", and even if we add something that can be saw this way in Gala, GSD won't use it anyway. i think the path forward here is moving out from GSD's MediaKeys plugin. and having the indicators deal with the keyboard shortcuts. that would have the plus that we won't end with a notification when the indicator popover is open, like happens now. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Works as expected.
…lementary/notifications into lenemter/replace-confirmations
Fixes #76
It's a bit broken for now.