Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MessageListItem: Parse message_info.from into a linkbutton #362

Draft
wants to merge 5 commits into
base: master
Choose a base branch
from

Conversation

danirabbit
Copy link
Member

Replaces the dumb label with a link style button that opens a mailto link, just like Mail 1.x did

@tintou
Copy link
Member

tintou commented Feb 17, 2019

I would prefer a single Gtk.Grid subclass for the field that holds the buttons and the entry:
Use Camel.InternetAddress class to parse the addresses instead of splitting < and > yourself so that it is handled consistently through the system.

@@ -462,4 +460,41 @@ public class Mail.MessageListItem : Gtk.ListBoxRow {
public string get_message_body_html () {
return web_view.get_body_html ();
}

private class IndividualItem : Gtk.Button {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why not subclass Gtk.LinkButton directly ?

@danirabbit
Copy link
Member Author

Ah hey I was looking for something like that, but couldn't find it. I'll update accordingly

@danirabbit
Copy link
Member Author

@tintou hm so I'm doing:

        string parsed_address;
        string parsed_name;

        var internet_address = new Camel.InternetAddress ();
        internet_address.unformat (message_info.from);
        internet_address.get (0, out parsed_name, out parsed_address);

and getting a segfault in malloc. Any ideas?

@danirabbit danirabbit marked this pull request as draft April 18, 2020 15:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants