Get prefers accent color from AccountsService #483
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Apr 11, 2021
JoseExposito
requested changes
Apr 11, 2021
| } | ||
| }); | ||
| } catch (Error e) { | ||
| critical (e.message); |
There was a problem hiding this comment.
It is very unlikely, but if GLib.Bus.get_proxy_sync fails, prefers_accent_color will return null.
I'm not sure which accent color is going to be the default one, but maybe we should fallback to it on error when _prefers_accent_color == null.
There was a problem hiding this comment.
I'm not quite sure. I simply copied and modified the code for ColorScheme 🤓️
cassidyjames
approved these changes
Apr 20, 2021
danirabbit
added a commit
that referenced
this pull request
May 3, 2021
This reverts commit a95c546.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #394
Could be handy for