Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Don't check for updates in the guest session #2090

Merged
merged 7 commits into from
Mar 12, 2024

Conversation

meisenzahl
Copy link
Member

Closes #2088

@meisenzahl meisenzahl marked this pull request as ready for review September 20, 2023 21:57
@meisenzahl meisenzahl requested a review from a team September 20, 2023 21:57
@danirabbit
Copy link
Member

I think we probably want to also remove or disable the "Check for updates" button, and possibly avoid showing the update list entirely in the installed view

@zeebok
Copy link
Contributor

zeebok commented Sep 21, 2023

If you do that, you might want to just remove the settings menu since the other option pertains to installing updates

@meisenzahl
Copy link
Member Author

Thank you very much for your feedback. @danirabbit could you please explain again in more detail what you mean by:

possibly avoid showing the update list entirely in the installed view

src/MainWindow.vala Outdated Show resolved Hide resolved
@danirabbit danirabbit force-pushed the dont-check-for-updates-in-the-guest-session branch from 1b515d3 to a59bba4 Compare March 12, 2024 17:54
@danirabbit danirabbit enabled auto-merge (squash) March 12, 2024 18:00
@danirabbit danirabbit merged commit 35ccd8d into main Mar 12, 2024
2 of 4 checks passed
@danirabbit danirabbit deleted the dont-check-for-updates-in-the-guest-session branch March 12, 2024 18:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

Don't check for updates in the guest session
3 participants