Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make loading updates async from main AppCenter window #1964

Merged
merged 9 commits into from
Jan 5, 2023
Merged

Make loading updates async from main AppCenter window #1964

merged 9 commits into from
Jan 5, 2023
+160 −27

Conversation

meisenzahl
Copy link
Member

@meisenzahl meisenzahl commented Dec 30, 2022 •
edited
Loading

Closes #1471

Debugged with Sysprof.

Before

After

@meisenzahl meisenzahl marked this pull request as ready for review January 3, 2023 05:16
@danirabbit danirabbit requested a review from a team January 3, 2023 20:39
zeebok
zeebok reviewed Jan 4, 2023
View reviewed changes
Copy link
Contributor

@zeebok zeebok left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code looks good. I am going to do some testing tomorrow and then give it approval

@danirabbit
Copy link
Member

So fast! 🚀

@danirabbit danirabbit merged commit e5dbee5 into master Jan 5, 2023
@danirabbit danirabbit deleted the make-loading-updates-async-from-main-appcenter-window branch January 5, 2023 16:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@zeebok zeebok zeebok left review comments

@danirabbit danirabbit danirabbit approved these changes

@davidmhewitt davidmhewitt Awaiting requested review from davidmhewitt

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Make loading updates async from main AppCenter window
3 participants
@meisenzahl @danirabbit @zeebok