-
Notifications
You must be signed in to change notification settings - Fork 416
Split homeserver creation and setup #19015
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
MadLittleMods
merged 16 commits into
develop
from
maddlittlemods/split-hs-creation-and-setup
Oct 9, 2025
Merged
Changes from 1 commit
Commits
Show all changes
16 commits
Select commit
Hold shift + click to select a range
73ddfba
Split homeserver creation and setup
MadLittleMods 3521c0e
Move start related things to `run()`
MadLittleMods e651544
Rename `run` -> `start` to match start things inside
MadLittleMods 29457a2
It's better if we do everything in `setup`
MadLittleMods b1f4478
Add plans
MadLittleMods 211765f
Move db_pool `start_doing_background_updates` to `start_background_ta…
MadLittleMods 2cf1f40
Add docstring
MadLittleMods 0967fdf
Revert "Move db_pool `start_doing_background_updates` to `start_backg…
MadLittleMods 0f50d26
Add changelog
MadLittleMods e4857c0
Merge branch 'develop' into maddlittlemods/split-hs-creation-and-setup
MadLittleMods ad3d981
Point out what not to do
MadLittleMods 18b42fb
Refactor in tests
MadLittleMods 32e5f4b
Update docstrings
MadLittleMods 16c7967
No need to pass in the whole homeserver (just pass homeserver config)
MadLittleMods 614307b
Merge branch 'develop' into maddlittlemods/split-hs-creation-and-setup
MadLittleMods b2a82e0
Merge branch 'develop' into maddlittlemods/split-hs-creation-and-setup
MadLittleMods File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Some comments aren't visible on the classic Files Changed page.
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
To document why I made the change to pass in the
HomeServerConfiginstead ofhstostart_reactor(...)(as I was having trouble remembering myself the day after):start_reactor(...)doesn't really have anything to do with the homeserver itself. This is just concerned with starting the Twisted event-loop that could be driving any application. And ideally, we wouldn't even pass something calledHomeServerConfigas this is more justReactorConfig. Currently just done out of convenience.