Work around twisted.protocols.amp.TooLong error by reducing logging in some tests.
#18736
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…_too_long Works around: twisted/twisted#12482 (amp.TooLong error)
Signed-off-by: Olivier 'reivilibre <[email protected]>
reivilibre
force-pushed
the
rei/trial_profile_too_long
branch
from
cbd5cf3 to
f0e934e
Compare
reivilibre
changed the title
twisted.protocols.amp.TooLong error by disabling SQL logging in ProfileTestCase.test_set_custom_field_profile_too_long test.twisted.protocols.amp.TooLong error by reducing logging in some tests.
23 tasks
MadLittleMods
approved these changes
Jul 29, 2025
| for i in range(100): | ||
| typing._push_update( | ||
| member=RoomMember(ROOM_ID, "@test%s:blue" % i), typing=True | ||
| # A huge RDATA log line is triggered in this test, which breaks trial |
There was a problem hiding this comment.
Suggested change
| # A huge RDATA log line is triggered in this test, which breaks trial | |
| # Because we emit a huge RDATA log line and trial sometimes crashes on these, | |
| # disable that logger for this test |
Comment on lines
103
to
104
| # A huge RDATA log line is triggered in this test, which breaks trial | ||
| # ref: https://github.com/twisted/twisted/issues/12482 |
There was a problem hiding this comment.
Alternative to actually call this out as a FIXME.
Suggested change
| # A huge RDATA log line is triggered in this test, which breaks trial | |
| # ref: https://github.com/twisted/twisted/issues/12482 | |
| # FIXME: Because we emit a huge RDATA log line and trial sometimes crashes on | |
| # these, disable that logger for this test. This can be removed once | |
| # https://github.com/twisted/twisted/issues/12482 is solved and we update | |
| # Twisted to version that includes the fix. |
(applies to other spot as well)
There was a problem hiding this comment.
annoyingly, given the olddeps trial run, we actually can't remove this for several years even if we fix Trial :D
There was a problem hiding this comment.
(guess I should add that caveat to the comment though)
This was referenced Jul 30, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Part of: #18537
Works around: twisted/twisted#12482
Silence SQL logs during ProfileTestCase.test_set_custom_field_profile_too_long
Works around:
trial -j<N>fails withtwisted.protocols.amp.TooLongwhen the application under test emits large log lines twisted/twisted#12482(amp.TooLong error)