Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: media worker serves client resources #17669

Closed

Conversation

johannes-krude
Copy link

@johannes-krude johannes-krude commented Sep 5, 2024

The workers documentation mentions that the media worker can handle the new endpoints for authenticated media, but the included example config misses the client resources.

I spent several hours debugging our synapse deployment and reverse proxy configuration to figure out the reason that element-desktop is no longer able to load avatars and uploaded images.

Without the client resource, the media worker responds with M_UNRECOGNIZED to ^/_matrix/client/v1/media/ requests and element-desktop shows "Unable to show image due to error".

Pull Request Checklist

  • Pull request is based on the develop branch
  • Pull request includes a changelog file. The entry should:
    • Be a short description of your change which makes sense to users. "Fixed a bug that prevented receiving messages from other servers." instead of "Moved X method from EventStore to EventWorkerStore.".
    • Use markdown where necessary, mostly for code blocks.
    • End with either a period (.) or an exclamation mark (!).
    • Start with a capital letter.
    • Feel free to credit yourself, by adding a sentence "Contributed by @github_username." or "Contributed by [Your Name]." to the end of the entry.

@johannes-krude johannes-krude requested a review from a team as a code owner September 5, 2024 12:23
@CLAassistant
Copy link

CLAassistant commented Sep 5, 2024

CLA assistant check
All committers have signed the CLA.

@anoadragon453
Copy link
Member

@johannes-krude did you test with Synapse v1.114+? As of that release, including only media should be enough to enable the authenticated media endpoints. See #17483

@anoadragon453 anoadragon453 removed the request for review from a team September 10, 2024 16:47
@github-actions github-actions bot deployed to PR Documentation Preview September 10, 2024 16:49 Active
@johannes-krude
Copy link
Author

I now upgraded to v1.114 and it works now without client.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants