Sliding Sync: Split up get_room_membership_for_user_at_to_token
#17629
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MadLittleMods
approved these changes
Aug 29, 2024
Comment on lines
648
to
650
| # Note: The `room_for_user` we're assigning here will need to be fixed up | ||
| # (below) because they are potentially from the current snapshot time | ||
| # instead from the time of the `to_token`. |
There was a problem hiding this comment.
I don't think this comment is accurate anymore since we just did the rewind above and only create the _RoomMembershipForUser once we have all of the info
| event_pos=room_for_user.event_pos, | ||
| membership=room_for_user.membership, | ||
| sender=room_for_user.sender, | ||
| # We will update these fields below to be accurate |
| event_pos=left_event_pos, | ||
| membership=Membership.LEAVE, | ||
| sender=None, | ||
| # We will update these fields below to be accurate |
|
|
||
| # 1) Fetch membership changes that fall in the range from `to_token` up to | ||
| # - a) Remove rooms that the user joined after the `to_token` | ||
| # - b) Add back rooms that the user left after the `to_token` |
There was a problem hiding this comment.
b) Add back rooms that the user left after the
to_token
I think this is outdated and we don't do this anymore 🤔
We just do c since the filtering that would have removed the left rooms was separated out to filter_rooms_relevant_for_sync/filter_membership_for_sync
There was a problem hiding this comment.
The 1b) and 1c) references need to be updated now that it was shuffled.
Co-authored-by: Eric Eastwood <[email protected]>
erikjohnston
force-pushed
the
erikj/ss_room_list_split
branch
from
a435d62
to
ed4ce95
Compare
erikjohnston
added a commit
that referenced
this pull request
Sep 1, 2024
Based on #17629 Utilizing the new sliding sync tables added in #17512 for fast acquisition of rooms for the user and filtering/sorting. --------- Co-authored-by: Eric Eastwood <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is to make it easier to reuse the logic when adding support for the new tables