Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Sliding Sync: Only send rooms with updates down sliding sync #17479

Merged
merged 56 commits into from
Jul 30, 2024
Merged
Show file tree
Hide file tree
Changes from 37 commits
Commits
Show all changes
56 commits
Select commit Hold shift + click to select a range
30263b4
Add SlidingSyncStreamToken
erikjohnston Jul 17, 2024
1ad1cce
Pass throught SlidingSyncStreamToken
erikjohnston Jul 16, 2024
e8df0d7
Don't create tokens manually in SSS tests
erikjohnston Jul 16, 2024
f3030af
Fix to use new token format
erikjohnston Jul 16, 2024
f3a4cfb
Newsfile
erikjohnston Jul 17, 2024
d44f7e1
WIP/PoC of storing whether we have sent rooms down to clients
erikjohnston Jul 15, 2024
53273db
Add conn_id field
erikjohnston Jul 17, 2024
e2a88e4
Use new room store to track if we've sent a room down
erikjohnston Jul 16, 2024
1858317
Handle initial flag correctly
erikjohnston Jul 17, 2024
de6e3bd
Handle state deltas in non-initial rooms
erikjohnston Jul 17, 2024
e2c47bf
Fix tests
erikjohnston Jul 17, 2024
a90c408
Newsfile
erikjohnston Jul 17, 2024
2968f2e
Bump typing-extensions for 'assert_never'
erikjohnston Jul 17, 2024
2784881
Add tests
erikjohnston Jul 17, 2024
d689204
Add docstring
erikjohnston Jul 18, 2024
560087b
Remove '_token' prefix
erikjohnston Jul 18, 2024
40d9587
Apply suggestions from code review
erikjohnston Jul 18, 2024
14eb781
Reword doc
erikjohnston Jul 18, 2024
9ae2551
Keyword args
erikjohnston Jul 18, 2024
51f7602
Rename bounds
erikjohnston Jul 18, 2024
eab092b
Add context to conn_id
erikjohnston Jul 18, 2024
605b358
Refactor to avoid SyncConfig.connection_id()
erikjohnston Jul 18, 2024
37c4463
Add some unit tests for 'get_room_sync_data'
erikjohnston Jul 18, 2024
7f26fc4
Merge remote-tracking branch 'origin/develop' into erikj/ss_room_store
erikjohnston Jul 18, 2024
532594e
Fix linting in tests
erikjohnston Jul 18, 2024
1230a51
Merge remote-tracking branch 'origin/develop' into erikj/ss_tokens
erikjohnston Jul 19, 2024
01f1dca
Merge branch 'erikj/ss_tokens' into erikj/ss_room_store
erikjohnston Jul 19, 2024
6f738a4
Apply suggestions from code review
erikjohnston Jul 23, 2024
588dfb8
Merge remote-tracking branch 'origin/develop' into erikj/ss_tokens
erikjohnston Jul 23, 2024
0c4e633
Fix tests
erikjohnston Jul 23, 2024
60790d6
Change token names again
erikjohnston Jul 23, 2024
4ce3e51
Ensure there is only one SlidingSyncHandler
erikjohnston Jul 23, 2024
602b6c8
Add test for cache being cleared
erikjohnston Jul 23, 2024
e2f3d48
Merge branch 'erikj/ss_tokens' into erikj/ss_room_store
erikjohnston Jul 23, 2024
81b2162
Merge remote-tracking branch 'origin/develop' into erikj/ss_room_store
erikjohnston Jul 24, 2024
75f7c01
Only send rooms with updates down sliding sync
erikjohnston Jul 24, 2024
b36cada
Newsfile
erikjohnston Jul 24, 2024
0812894
Update comments
erikjohnston Jul 25, 2024
66f80cc
Merge remote-tracking branch 'origin/develop' into erikj/ss_room_store
erikjohnston Jul 25, 2024
2c48784
Use do_sync in tests
erikjohnston Jul 25, 2024
abd7a5b
Move to integration tests
erikjohnston Jul 25, 2024
470c5d3
Review comments
erikjohnston Jul 26, 2024
90f2184
Previously state test
erikjohnston Jul 26, 2024
e7a6c19
Add never test
erikjohnston Jul 26, 2024
b9facaf
Review comments
erikjohnston Jul 26, 2024
b396450
Add test that empty room comes down initial sync
erikjohnston Jul 26, 2024
c56a745
Make it clear we only filter out rooms in incremental sync
erikjohnston Jul 26, 2024
c53e83d
Don't send down rooms if nothing has happened
erikjohnston Jul 26, 2024
1740f11
Merge remote-tracking branch 'origin/erikj/ss_room_store' into erikj/…
erikjohnston Jul 26, 2024
fd61672
Add dedicated function 'get_rooms_that_might_have_updates'
erikjohnston Jul 26, 2024
7ae5f78
Apply suggestions from code review
erikjohnston Jul 29, 2024
76c69e6
Add clarifying comments
erikjohnston Jul 29, 2024
d043009
Merge remote-tracking branch 'origin/develop' into erikj/ss_noop_rooms
erikjohnston Jul 29, 2024
4646edb
Fix comment
erikjohnston Jul 29, 2024
7088cb0
Apply suggestions from code review
erikjohnston Jul 29, 2024
07c0561
Change comment and andd assertion
erikjohnston Jul 29, 2024
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions changelog.d/17447.feature
Original file line number Diff line number Diff line change
@@ -0,0 +1 @@
Track which rooms have been sent to clients in the experimental [MSC3575](https://github.com/matrix-org/matrix-spec-proposals/pull/3575) Sliding Sync `/sync` endpoint.
1 change: 1 addition & 0 deletions changelog.d/17479.misc
Original file line number Diff line number Diff line change
@@ -0,0 +1 @@
Do not send down empty room entries down experimental sliding sync endpoint.
4 changes: 2 additions & 2 deletions pyproject.toml
Original file line number Diff line number Diff line change
Expand Up @@ -201,8 +201,8 @@ netaddr = ">=0.7.18"
# add a lower bound to the Jinja2 dependency.
Jinja2 = ">=3.0"
bleach = ">=1.4.3"
# We use `Self`, which were added in `typing-extensions` 4.0.
typing-extensions = ">=4.0"
# We use `assert_never`, which were added in `typing-extensions` 4.1.
typing-extensions = ">=4.1"
# We enforce that we have a `cryptography` version that bundles an `openssl`
# with the latest security patches.
cryptography = ">=3.4.7"
Expand Down
Loading
Loading