Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rename to be obvious: joined_rooms -> joined_room_ids #17203

Merged
merged 2 commits into from
May 16, 2024
+3 −2
Merged

Rename to be obvious: joined_rooms -> joined_room_ids #17203

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
d0d4035
Rename to be obvious room -> room_id
MadLittleMods May 15, 2024
62ff9dd
Add changelog
MadLittleMods May 15, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions changelog.d/17203.misc
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1 @@
Rename to be obvious: `joined_rooms` -> `joined_room_ids`.
4 changes: 2 additions & 2 deletions synapse/handlers/sync.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1799,7 +1799,7 @@ async def _generate_sync_entry_for_device_list(

users_that_have_changed = set()

joined_rooms = sync_result_builder.joined_room_ids
joined_room_ids = sync_result_builder.joined_room_ids

# Step 1a, check for changes in devices of users we share a room
# with
Expand Down Expand Up @@ -1833,7 +1833,7 @@ async def _generate_sync_entry_for_device_list(
# Remove any users that we still share a room with.
left_users_rooms = await self.store.get_rooms_for_users(newly_left_users)
for user_id, entries in left_users_rooms.items():
if any(rid in joined_rooms for rid in entries):
if any(rid in joined_room_ids for rid in entries):
newly_left_users.discard(user_id)

return DeviceListUpdates(changed=users_that_have_changed, left=newly_left_users)
Expand Down
Loading