Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Clarifications to enable_authenticated_media #17663

Open
reivilibre opened this issue Sep 4, 2024 · 1 comment · May be fixed by #17913
Open

Clarifications to enable_authenticated_media #17663

reivilibre opened this issue Sep 4, 2024 · 1 comment · May be fixed by #17913
Assignees

Comments

@reivilibre
Copy link
Contributor

reivilibre commented Sep 4, 2024

Some of the semantics around media access are not especially clear from the config manual and I realised I did not understand it as well as I thought I did.

I think this could be cleared up with a case by case breakdown?

  • enable_authenticated_media = False:
    • unauthenticated client or homeserver requesting local media: accepted
    • unauthenticated client or homeserver requesting remote media: accepted as long as the media is in the cache, or the remote homeserver does not require authentication to retrieve the media
  • enable_authenticated_media = True:
    • unauthenticated client or homeserver requesting local media: denied unless the media was stored on the server before enable_authenticated_media was True
    • unauthenticated client or homeserver requesting remote media: the same; denied unless the media was stored on the server before enable_authenticated_media was True

In all cases, authenticated clients or homeservers are allowed to access media (with the usual caveat that we won't perform a media fetch over federation on behalf of another federated homeserver)

Also note that each piece of media 'remembers' the flag at the time it is saved, so if you switch it to true(1) , back to false (2), then back to true (3), both media from (1) and (3) will be considered as 'requiring authentication'. Not sure how to phrase this nicely for the manual but may be worthwhile to know.

@reivilibre reivilibre self-assigned this Sep 4, 2024
@daedric7
Copy link

Also note that each piece of media 'remembers' the flag at the time it is saved, so if you switch it to true(1) , back to false (2), then back to true (3), both media from (1) and (3) will be considered as 'requiring authentication'. Not sure how to phrase this nicely for the manual but may be worthwhile to know.

All media uploaded by a user while this flag is ON will be tagged as "authenticated only" and will not be available on legacy endpoints, regardless of the status of the enable_authenticated_media.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants