Skip to content

Commit 70987fa

Browse files
committed
Add logging for live debugging
1 parent 7f2d834 commit 70987fa

File tree

1 file changed

+7
-0
lines changed

1 file changed

+7
-0
lines changed

synapse/handlers/room_policy.py

Lines changed: 7 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -58,24 +58,29 @@ async def is_event_allowed(self, event: EventBase) -> bool:
5858
event.room_id, "org.matrix.msc4284.policy", ""
5959
)
6060
if not policy_event:
61+
logger.info("Allowing %s due to no policy event", event.event_id)
6162
return True # no policy server == default allow
6263

6364
policy_server = policy_event.content.get("via", "")
6465
if policy_server is None or not isinstance(policy_server, str):
66+
logger.info("Allowing %s due to missing via", event.event_id)
6567
return True # no policy server == default allow
6668

6769
if policy_server == self._hs.hostname:
70+
logger.info("Allowing %s due to self policy server", event.event_id)
6871
return True # Synapse itself can't be a policy server (currently)
6972

7073
try:
7174
parse_and_validate_server_name(policy_server)
7275
except ValueError:
76+
logger.info("Allowing %s due to invalid policy server name", event.event_id)
7377
return True # invalid policy server == default allow
7478

7579
is_in_room = await self._event_auth_handler.is_host_in_room(
7680
event.room_id, policy_server
7781
)
7882
if not is_in_room:
83+
logger.info("Allowing %s due to policy server not in room", event.event_id)
7984
return True # policy server not in room == default allow
8085

8186
# At this point, the server appears valid and is in the room, so ask it to check
@@ -84,6 +89,8 @@ async def is_event_allowed(self, event: EventBase) -> bool:
8489
policy_server, event
8590
)
8691
if recommendation != RECOMMENDATION_OK:
92+
logger.info("Denying %s due to policy server", event.event_id)
8793
return False
8894

95+
logger.info("Allowing %s due to policy server saying so", event.event_id)
8996
return True # default allow

0 commit comments

Comments
 (0)