Skip to content

Commit 7f2d834

Browse files
committed
Use parse_and_validate_server_name
1 parent aad740a commit 7f2d834

File tree

1 file changed

+4
-2
lines changed

1 file changed

+4
-2
lines changed

synapse/handlers/room_policy.py

Lines changed: 4 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -18,8 +18,8 @@
1818
from typing import TYPE_CHECKING
1919

2020
from synapse.events import EventBase
21-
from synapse.types import UserID
2221
from synapse.types.handlers.policy_server import RECOMMENDATION_OK
22+
from synapse.util.stringutils import parse_and_validate_server_name
2323

2424
if TYPE_CHECKING:
2525
from synapse.server import HomeServer
@@ -67,7 +67,9 @@ async def is_event_allowed(self, event: EventBase) -> bool:
6767
if policy_server == self._hs.hostname:
6868
return True # Synapse itself can't be a policy server (currently)
6969

70-
if not UserID.is_valid("@x:" + policy_server):
70+
try:
71+
parse_and_validate_server_name(policy_server)
72+
except ValueError:
7173
return True # invalid policy server == default allow
7274

7375
is_in_room = await self._event_auth_handler.is_host_in_room(

0 commit comments

Comments
 (0)