Rename to be obvious: joined_rooms -> joined_room_ids (#17203)

Split out from #17167
element-hq · May 16, 2024 · 52a6495 · 52a6495
1 parent 28a948f
commit 52a6495
Show file tree

Hide file tree

Showing 2 changed files with 3 additions and 2 deletions.
diff --git a/changelog.d/17203.misc b/changelog.d/17203.misc
@@ -0,0 +1 @@
+Rename to be obvious: `joined_rooms` -> `joined_room_ids`.
diff --git a/synapse/handlers/sync.py b/synapse/handlers/sync.py
@@ -1850,7 +1850,7 @@ async def _generate_sync_entry_for_device_list(
 
         users_that_have_changed = set()
 
-        joined_rooms = sync_result_builder.joined_room_ids
+        joined_room_ids = sync_result_builder.joined_room_ids
 
         # Step 1a, check for changes in devices of users we share a room
         # with
@@ -1909,7 +1909,7 @@ async def _generate_sync_entry_for_device_list(
         # Remove any users that we still share a room with.
         left_users_rooms = await self.store.get_rooms_for_users(newly_left_users)
         for user_id, entries in left_users_rooms.items():
-            if any(rid in joined_rooms for rid in entries):
+            if any(rid in joined_room_ids for rid in entries):
                 newly_left_users.discard(user_id)
 
         return DeviceListUpdates(changed=users_that_have_changed, left=newly_left_users)
Original file line number	Diff line number	Diff line change
		@@ -0,0 +1 @@
		Rename to be obvious: `joined_rooms` -> `joined_room_ids`.