-
Notifications
You must be signed in to change notification settings - Fork 394
Add builtin emoji support #2187
base: develop
Are you sure you want to change the base?
Add builtin emoji support #2187
Conversation
…nto inapp-emoji-support
Hi @Foo-Manroot , Thanks for the PR. Contribution guide has been followed :) . We will discuss internally to decide if we can merge it. Do you know what can be the impacts on the other client (iOS/Web) when emojis are sent? Benoît |
When users use android-riot app - they see emoji from android. Compare emoji: This is not bad (riot-android) (for samsung smartphones it is more nicely, then clear android): Default emoji in riot is ugly. I sink, that it is good patch, but before apply this patch, we need replace default emoji. And then, all emoji will be some on all devices and they will be nice. |
I... don't really know what's your point, @progserega; but I think there has been a consensus over at #android:matrix.org about giving the option to use these new font or the default one through configuration. Right now I'm quite busy and I don't think I may be able to take a look at it in a while, but I encourage anyone to try to implement this as configurable feature. |
ok |
Before this series of commits, the emojis shown on the device where vendor-specific and relied on the keyboard to be inserted. Now, there's an integrated popup where one can insert emojis. Also, the displayed emojis are changed, as shown on the image:
The library that I used was vannkitec's, but some changes were needed to integrate it on this project, so I made a couple of modifications for that purpose. Until the new build is released, those changes are only available on the snapshot.
The emojis used are the ones from emoji-one for personal reasons (those were the ones I liked the most); but it can be changed easily modifying the dependency.
For more discussion about the need for built-in emoji support, refer to #819
I tried to follow the contribution guides; but I may have missed something. In that case, I'd appreciate some comments and I'll try to fix whatever problem there may be.
Signed-off-by: Foo-Manroot [email protected]