Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update vite & related packages & remove hack_exports.js #33

Merged
merged 3 commits into from
Dec 23, 2024

Conversation

t3chguy
Copy link
Member

@t3chguy t3chguy commented Dec 23, 2024

No description provided.

@codecov-commenter
Copy link

codecov-commenter commented Dec 23, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 88.71%. Comparing base (e88ee8f) to head (b94addf).

Additional details and impacted files
@@            Coverage Diff             @@
##             main      #33      +/-   ##
==========================================
- Coverage   88.88%   88.71%   -0.18%     
==========================================
  Files         151       95      -56     
  Lines       20789    16574    -4215     
  Branches      291      291              
==========================================
- Hits        18479    14703    -3776     
+ Misses       2307     1868     -439     
  Partials        3        3              
Flag Coverage Δ
unittests 88.71% <ø> (-0.18%) ⬇️
unittests-ios ?
unittests-react 83.08% <ø> (-5.18%) ⬇️
unittests-rust 89.28% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@t3chguy t3chguy marked this pull request as ready for review December 23, 2024 10:01
@t3chguy t3chguy requested review from a team and dbkr and removed request for a team December 23, 2024 10:01
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Presumably because it uses npm? Is there any doc to say so?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

platforms/web was already yarn-only before hand
Removing remaining confusion in #34

@t3chguy t3chguy merged commit 2a08466 into main Dec 23, 2024
9 checks passed
@t3chguy t3chguy deleted the t3chguy/tidy-web branch December 23, 2024 10:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
T-Enhancement Improvement or feature request Web
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants