Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement MSC4142: Remove unintentional intentional mentions in replies #30

Open
wants to merge 1 commit into
base: develop
Choose a base branch
from

Conversation

tulir
Copy link

@tulir tulir commented Sep 11, 2024

Fixes element-hq/element-web#27291
Implements matrix-org/matrix-spec-proposals#4142
Re-opened version of matrix-org/matrix-react-sdk#12511

The current spec is just a recommendation, so following it is not required and this can be merged already before the MSC is accepted. The goal of the MSC is to remove the dumb recommendation from the spec

For context:

  • Old behavior before intentional mentions: reply fallbacks caused replies to mention the sender of the replied-to message, as well as any users explicitly mentioned in the replied-to message
  • Current behavior in Element: replies mention the sender of the replied-to message, as well as all users explicitly or implicitly mentioned in the replied-to message. Implicit mentions includes any mentions from earlier in the reply chain (like the senders of all previous messages and any users ever mentioned in the chain)
  • New behavior after this PR: replies mention the sender of the replied-to message

In all cases, new explicit mentions are also of course included

@tulir tulir requested a review from a team as a code owner September 11, 2024 18:12
@CLAassistant
Copy link

CLAassistant commented Sep 11, 2024

CLA assistant check
All committers have signed the CLA.

@dbkr
Copy link
Member

dbkr commented Sep 12, 2024

I've pinged product over on the issue to ensure this is what we want. Code look fine though. Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Mentioned by reply to message that mentioned me
3 participants