This repository has been archived by the owner on Oct 22, 2024. It is now read-only.
Log clearer errors when picklekey goes missing #27
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
richvdh
changed the title
Improve variable naming and documentation on the methods in `tokens.ts`.
Since the session data isn't actually stored in localstorage, this feels like a misleading name.
richvdh
force-pushed
the
rav/token_encryption_improvements
branch
from
ab50038
to
722c3a3
Compare
Currently, if we have an accesstoken which is encrypted with a picklekey, but the picklekey has gone missing, we carry on with no access token at all. This is sure to blow up in some way or other later on, but in a rather cryptic way. Instead, let's bail out early. (This will produce a "can't restore session" error, but we normally see one of those anyway because we can't initialise the crypto store.)
richvdh
force-pushed
the
rav/token_encryption_improvements
branch
from
722c3a3
to
c6359d6
Compare
|
robintown
approved these changes
Sep 11, 2024
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently, if we have an accesstoken which is encrypted with a picklekey, but the picklekey has gone missing, we carry on with no access token at all. This is sure to blow up in some way or other later on, but in a rather cryptic way.
Instead, let's bail out early.
(This will produce a "can't restore session" error, but we normally see one of those anyway because we can't initialise the crypto store.)
Also a couple of refactoring commits to bring a bit more sanity to this part of the code. Suggest review commit-by-commit.
This is part of a quest to hunt down WTF is going on with element-hq/element-desktop#1816.