Skip to content
This repository has been archived by the owner on Oct 22, 2024. It is now read-only.

Add timezone to user profile #20

Merged
merged 27 commits into from
Sep 12, 2024
Merged

Add timezone to user profile #20

merged 27 commits into from
Sep 12, 2024

Conversation

Half-Shot
Copy link
Member

@Half-Shot Half-Shot commented Sep 10, 2024 •
edited
Loading

Migrated from matrix-org/matrix-react-sdk#12967
Implements MSC4175
Depends on matrix-org/matrix-js-sdk#4391

Design provided at https://www.figma.com/design/gpxHFDTNK796n84r1ZxYG2?node-id=1360-28954#941702635

This provides a basic presentation of a user's current time & timezone on their profile. It also adds a setting to allow publishing the time.

Timezone in user profile

image

Timezone publish setting

image

Checklist

  • Tests written for new code (and old code if feasible).
  • New or updated public/exported symbols have accurate TSDoc documentation.
  • Linter and other CI checks pass.
  • Sign-off given on the changes (see CONTRIBUTING.md).

Signed-off-by: Will Hunt [email protected]

RiotRobot and others added 19 commits September 6, 2024 06:16
@RiotRobot
[create-pull-request] automated change (#12966)
33c9c04 
Co-authored-by: github-merge-queue <[email protected]>
@Half-Shot
Add timezone to right panel profile.
05b1826
@Half-Shot
Add setting to publish timezone
c103109
@Half-Shot
Add string for timezone publish
d9238c7
@Half-Shot
Automatically update timezone when setting changes.
e78dfc2
@Half-Shot
Refactor to using a hook
6989162 
And automatically refresh the timezone every minute.
@Half-Shot
Check for feature support for extended profiles.
34d3176
@Half-Shot
lint
8e39e06
@Half-Shot
Add timezone
6fc5450
@Half-Shot
Remove unintentional changes
96d7fda
@Half-Shot
Use browser default timezone.
8ec6294
@Half-Shot
lint
45285f2
@Half-Shot
tweaks
5ae6e2e
@Half-Shot
Set timezone publish at the device level to prevent all devices writi…
b12e4cd 
…ng to the timezone field.
@Half-Shot
Update hook to use external client.
8c18fce
@Half-Shot
Add test for user timezone.
4e11e7d
@Half-Shot
Update snapshot for preferences tab.
b176ca8
@Half-Shot
Hide timezone info if not provided.
2a14aee
@Half-Shot
Stablize test
c43048d
@Half-Shot Half-Shot requested a review from a team as a code owner September 10, 2024 10:02
@CLAassistant
Copy link

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.
You have signed the CLA already but the status is still pending? Let us recheck it.

@Half-Shot Half-Shot changed the title Hs/timezone publish to profile Add timezone to user profile Sep 10, 2024
Half-Shot
Half-Shot commented Sep 10, 2024
View reviewed changes
src/i18n/strings/pl.json Outdated
@@ -1841,10 +1841,25 @@
"files_button": "Pliki",
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These changes came from 33c9c04, I don't know whether I should remove them from my commit list to make the CI pass or just ignore it?

@Half-Shot
Copy link
Member Author

@dbkr PR ended up moving here, if you wouldn't mind a re-review (sorry!)

@Half-Shot Half-Shot requested review from dbkr and removed request for florianduros and robintown September 10, 2024 14:10
@dbkr
Copy link
Member

dbkr commented Sep 10, 2024

Looks good. For the end to end tests, you'll just need to run the command to update the screenshot file. For sonarcloud coverage... it's whining because the code to update / delete the timezone is not tested, which feels legit I think. Any chance of a test for this?

@clokep clokep mentioned this pull request Sep 10, 2024
Open
@tcpipuk tcpipuk mentioned this pull request Sep 11, 2024
Open
@Half-Shot
Copy link
Member Author

@dbkr New tests added and screenshots fixed, I think this is ready for you to look at.

@sonarcloud SonarCloud
Copy link

sonarcloud bot commented Sep 12, 2024

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
85.6% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud

@Half-Shot
Copy link
Member Author

(I have CLA'd, but it seems to think I have not)

@dbkr dbkr added this pull request to the merge queue Sep 12, 2024
Merged via the queue into develop with commit eae9d9e Sep 12, 2024
26 of 27 checks passed
@dbkr dbkr deleted the hs/timezone-publish-to-profile branch September 12, 2024 13:33
@tcpipuk tcpipuk mentioned this pull request Sep 14, 2024
Open
bmwiedemann pushed a commit to bmwiedemann/openSUSE that referenced this pull request Oct 6, 2024
@bmwiedemann
Update element-web to version 1.11.79 / rev 64 via SR 1205714
727939c 
https://build.opensuse.org/request/show/1205714
by user dheidler + anag+factory
- Version 1.11.79
  * No changes
  ## ✨ Features
  * element-hq/matrix-react-sdk#106). Contributed by @RiotRobot.

- Version 1.11.78
  ## ✨ Features

  * Add Release announcement for the pinning message list (element-hq/matrix-react-sdk#46). Contributed by @florianduros.
  * Unlabs feature pinning (element-hq/matrix-react-sdk#22). Contributed by @florianduros.
  * Add mobile registration (element-hq/matrix-react-sdk#42). Contributed by @langleyd.
  * Add support for `org.matrix.cross_signing_reset` UIA stage flow (element-hq/matrix-react-sdk#34). Contributed by @t3chguy.
  * Add timezone to user profile (element-hq/matrix-react-sdk#20). Contribute
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@dbkr dbkr dbkr approved these changes

Assignees
No one assigned
Labels
T-Enhancement
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@Half-Shot @CLAassistant @dbkr @RiotRobot