-
Notifications
You must be signed in to change notification settings - Fork 16
Restrict access to LiveKit SFU by differentiating full-access and restricted Matrix users for room creation #67
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
2d8d17f to
5191cd9
Compare
…dling of local and remote users
36391d5 to
56e20c5
Compare
|
@fkwp Do you know why this hasn't been merged, yet? As a spectator I can't tell what's still missing to get this merged. |
This is currently blocked by a missing MatrixRTC client implementation which requires more robust handling of SFU error cases. |
…to mimic the current behaviour
…etJoinToken since the lk-jwt-service takes care of creating required rooms.
…nd adapt logging.
4aad0f3 to
ff1502b
Compare
BillCarsonFr
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think the readme Installation section is outdated and miss the new -e LIVEKIT_FULL_ACCESS_HOMESERVERS = (per my understanding it is required)
Other than that, just some nits
…it defaulting to *
Updated the readme 8cfc4db currently its defaulting to |
BillCarsonFr
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ok.
Closes: #95
To ensure the proper and secure use of infrastructure
Note due to the SFU selection algorithm and the order of events this will NOT limit or prevent video conferences across Matrix federation.
Homeservers of full-access users are defined by the
LIVEKIT_LOCAL_HOMESERVERSLIVEKIT_FULL_ACCESS_HOMESERVERSenvironment variable via a comma separated list. It supports*as a wildcard to give full-access to users from all homeservers.Note this requires MatrixRTC client implementation with more robust handling of SFU error cases. Hence, for now we recommend using it with
LIVEKIT_FULL_ACCESS_HOMESERVERS=*