Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

QR Code Login Flow #2767

Merged
merged 56 commits into from
May 29, 2024
Merged

QR Code Login Flow #2767

merged 56 commits into from
May 29, 2024

Conversation

Velin92
Copy link
Member

@Velin92 Velin92 commented Apr 29, 2024 •
edited
Loading

fixes #2622

Velin92 and others added 15 commits April 12, 2024 17:57
@Velin92
progress
4a42e4d
@Velin92
qr code scanning now works, but the API is still unstable
9744e6d
@Velin92
code improvements
aee72b7
@Velin92
code improvements
04aa596
@Velin92
improved state handling
086cb30
@Velin92
improved the flow
223cf43
@Velin92
the flow can now reach the login state
529d943
@Velin92
now the code has also a string representation
1ff6cb4
@Velin92
fix onboarding
107f1fa
@Velin92
possible fix
1060bf6
@Velin92
qr code flow
00345b2
@Velin92
possible fix
3741c62
@Velin92
fix for the connecting state not working properly
9d2f179
@Velin92
Merge branch 'develop' of https://github.com/vector-im/element-x-ios …
638c298 
…into mauroromito/qr_code_api_testing

# Conflicts:
#	ElementX/Sources/Application/AppSettings.swift
#	ElementX/Sources/FlowCoordinators/AuthenticationFlowCoordinator.swift
#	ElementX/Sources/Screens/QRCodeLoginScreen/QRCodeLoginScreenViewModel.swift
#	ElementX/Sources/Services/Authentication/AuthenticationServiceProxy.swift
@Velin92
Discard changes to ElementX.xcodeproj/project.xcworkspace/xcshareddat…
64b7934 
…a/swiftpm/Package.resolved
@github-actions GitHub Actions
Copy link

github-actions bot commented Apr 29, 2024 •
edited
Loading

Warnings
⚠️ This pull request seems relatively large. Please consider splitting it into multiple smaller ones.
⚠️ Please add a changelog.
⚠️ Some of the commits are missing ticket numbers. Please consider squashing all commits that don't have a tracking number.
⚠️ You seem to have made changes to views. Please consider adding screenshots.

Generated by 🚫 Danger Swift against 683a534

@Velin92 Velin92 added the Trigger-PR-Build Uses to trigger alpha builds for PRs label May 2, 2024
@github-actions GitHub Actions
Copy link

github-actions bot commented May 2, 2024 •
edited
Loading

📱 Scan the QR code below to install the build for this PR.
🔒 This build is for internal testing purpose. Only devices listed in the ad-hoc provisioning profile can install Element Alpha.

QR code

If you can't scan the QR code you can install the build via this link: https://i.diawi.com/Ceqb8g

@Velin92
code improvement
6b4d84e
@Velin92
updated qr code login
6b56f17
@Velin92
Merge branch 'develop' of https://github.com/vector-im/element-x-ios …
a3ac12a 
…into mauroromito/qr_code_api_testing

# Conflicts:
#	ElementX.xcodeproj/project.pbxproj
#	ElementX.xcodeproj/project.xcworkspace/xcshareddata/swiftpm/Package.resolved
#	project.yml
@Velin92
updated previews and added an error for the
a60b19a 
sliding sync not being supported
@Velin92
Merge branch 'develop' of https://github.com/vector-im/element-x-ios …
26dfc77 
…into mauroromito/qr_code_api_testing

# Conflicts:
#	ElementX.xcodeproj/project.pbxproj
#	ElementX.xcodeproj/project.xcworkspace/xcshareddata/swiftpm/Package.resolved
#	project.yml
@Velin92
updated sdk
1e7b74b
@Velin92 Velin92 marked this pull request as ready for review May 29, 2024 08:59
@Velin92 Velin92 requested a review from a team as a code owner May 29, 2024 08:59
@Velin92 Velin92 requested review from stefanceriu and removed request for a team May 29, 2024 08:59
@Velin92 Velin92 changed the title [WIP] QR Code Login Flow QR Code Login Flow May 29, 2024
stefanceriu
stefanceriu approved these changes May 29, 2024
View reviewed changes
Copy link
Member

@stefanceriu stefanceriu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, great to finally see it over the line! Very well done! 👏

ElementX/Sources/Other/Extensions/AVMetadataMachineReadableCodeObject.swift Show resolved Hide resolved
ElementX/Sources/Other/Extensions/AVMetadataMachineReadableCodeObject.swift Show resolved Hide resolved
ElementX/Sources/Screens/QRCodeLoginScreen/View/QRCodeLoginScreen.swift Outdated Show resolved Hide resolved
ElementX/Sources/Screens/QRCodeLoginScreen/View/QRCodeScannerView.swift Show resolved Hide resolved
ElementX/Sources/Screens/QRCodeLoginScreen/View/QRCodeScannerView.swift Outdated Show resolved Hide resolved
ElementX/Sources/Services/Client/ClientProxy.swift Outdated Show resolved Hide resolved
ElementX/Sources/Services/QRCode/QRCodeLoginService.swift Show resolved Hide resolved
ElementX/Sources/Services/QRCode/QRCodeLoginService.swift Outdated Show resolved Hide resolved
@sonarcloud SonarCloud
Copy link

sonarcloud bot commented May 29, 2024

Quality Gate Passed Quality Gate passed

Issues
2 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarCloud

@Velin92 Velin92 merged commit 4e23f7b into develop May 29, 2024
9 checks passed
@Velin92 Velin92 deleted the mauroromito/qr_code_api_testing branch May 29, 2024 15:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hughns hughns hughns left review comments

@pixlwave pixlwave pixlwave left review comments

@stefanceriu stefanceriu stefanceriu approved these changes

Assignees
No one assigned
Labels
Trigger-PR-Build Uses to trigger alpha builds for PRs
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Task] Sign in with QR code
4 participants
@Velin92 @stefanceriu @pixlwave @hughns