Skip to content

Always attempt to start the sync when starting the application. #4069

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Dec 19, 2024

Conversation

bmarty
Copy link
Member

@bmarty bmarty commented Dec 19, 2024

Content

Motivation and context

The sync loop may not be started in the case that the network is not detected.
This change ensure that the sync will be started at least once every time the application is started, waiting for a long term fix which will require change on the SDK.

Screenshots / GIFs

Tests

  • Step 1
  • Step 2
  • Step ...

Tested devices

  • Physical
  • Emulator
  • OS version(s):

Checklist

@bmarty bmarty requested a review from a team as a code owner December 19, 2024 11:36
@bmarty bmarty requested review from ganfra and removed request for a team December 19, 2024 11:36
@bmarty bmarty added the PR-Bugfix For bug fix label Dec 19, 2024
Copy link
Contributor

github-actions bot commented Dec 19, 2024

📱 Scan the QR code below to install the build (arm64 only) for this PR.
QR code
If you can't scan the QR code you can install the build via this link: https://i.diawi.com/PSFQZf

Copy link

codecov bot commented Dec 19, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 83.11%. Comparing base (a69b04e) to head (c4fd20f).
Report is 3 commits behind head on develop.

Additional details and impacted files
@@           Coverage Diff            @@
##           develop    #4069   +/-   ##
========================================
  Coverage    83.11%   83.11%           
========================================
  Files         1872     1872           
  Lines        48724    48724           
  Branches      5698     5698           
========================================
  Hits         40498    40498           
  Misses        6187     6187           
  Partials      2039     2039           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@ganfra ganfra left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@bmarty bmarty force-pushed the feature/bma/startSync branch from 350bc7a to c4fd20f Compare December 19, 2024 12:45
@ganfra ganfra added the Run-Maestro Starts a Maestro Cloud session to run integration tests label Dec 19, 2024
@github-actions github-actions bot removed the Run-Maestro Starts a Maestro Cloud session to run integration tests label Dec 19, 2024
@bmarty bmarty enabled auto-merge December 19, 2024 14:01
@bmarty bmarty merged commit 5189eb4 into develop Dec 19, 2024
30 checks passed
@bmarty bmarty deleted the feature/bma/startSync branch December 19, 2024 14:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
PR-Bugfix For bug fix
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants