Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add a quick filter on the open source licence screen. #4052

Merged
merged 2 commits into from
Dec 17, 2024

Conversation

bmarty
Copy link
Member

@bmarty bmarty commented Dec 16, 2024

Content

We have about 300 licences in shown in the open source screen and it can be painful to search for a specific license. This PR add a way to filter by name / groupId / artifactId.

Motivation and context

Screenshots / GIFs

See recorder one

Tests

  • Navigate to Settings/About/Open source license
  • Play with the new filter.

Tested devices

  • Physical
  • Emulator
  • OS version(s):

Checklist

@bmarty bmarty added Record-Screenshots Runs the 'Record Screenshots' CI job and adds a commit with any new screenshots found. PR-Misc For other changes labels Dec 16, 2024
@bmarty bmarty requested a review from a team as a code owner December 16, 2024 16:39
@bmarty bmarty requested review from ganfra and removed request for a team December 16, 2024 16:39
@github-actions github-actions bot removed the Record-Screenshots Runs the 'Record Screenshots' CI job and adds a commit with any new screenshots found. label Dec 16, 2024
Copy link
Contributor

github-actions bot commented Dec 16, 2024

📱 Scan the QR code below to install the build (arm64 only) for this PR.
QR code
If you can't scan the QR code you can install the build via this link: https://i.diawi.com/pbSphr

Copy link

codecov bot commented Dec 16, 2024

Codecov Report

Attention: Patch coverage is 94.44444% with 3 lines in your changes missing coverage. Please review.

Project coverage is 82.95%. Comparing base (66ca329) to head (1446524).
Report is 10 commits behind head on develop.

Files with missing lines Patch % Lines
...s/licenses/impl/list/DependencyLicensesListView.kt 92.30% 1 Missing and 1 partial ⚠️
...s/impl/list/DependencyLicensesListStateProvider.kt 92.85% 1 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff            @@
##           develop    #4052   +/-   ##
========================================
  Coverage    82.94%   82.95%           
========================================
  Files         1864     1865    +1     
  Lines        48526    48556   +30     
  Branches      5696     5697    +1     
========================================
+ Hits         40252    40281   +29     
- Misses        6250     6251    +1     
  Partials      2024     2024           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@bmarty bmarty merged commit b7dd490 into develop Dec 17, 2024
26 checks passed
@bmarty bmarty deleted the feature/bma/licenceFilter branch December 17, 2024 09:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
PR-Misc For other changes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants