Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Accept-Language to extra header when opening CustomChromeTab #4051

Merged
merged 1 commit into from
Dec 17, 2024

Conversation

bmarty
Copy link
Member

@bmarty bmarty commented Dec 16, 2024

@bmarty bmarty requested a review from a team as a code owner December 16, 2024 15:59
@bmarty bmarty requested review from ganfra and removed request for a team December 16, 2024 15:59
@bmarty bmarty added the PR-i18n For translations label Dec 16, 2024
Copy link
Contributor

📱 Scan the QR code below to install the build (arm64 only) for this PR.
QR code
If you can't scan the QR code you can install the build via this link: https://i.diawi.com/e7AeVJ

Copy link

codecov bot commented Dec 16, 2024

Codecov Report

Attention: Patch coverage is 0% with 3 lines in your changes missing coverage. Please review.

Project coverage is 82.94%. Comparing base (66ca329) to head (d250b88).
Report is 10 commits behind head on develop.

Files with missing lines Patch % Lines
.../libraries/androidutils/browser/ChromeCustomTab.kt 0.00% 3 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff             @@
##           develop    #4051      +/-   ##
===========================================
- Coverage    82.94%   82.94%   -0.01%     
===========================================
  Files         1864     1864              
  Lines        48526    48529       +3     
  Branches      5696     5696              
===========================================
  Hits         40252    40252              
- Misses        6250     6253       +3     
  Partials      2024     2024              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@bmarty bmarty merged commit 411c336 into develop Dec 17, 2024
28 of 30 checks passed
@bmarty bmarty deleted the feature/bma/customChromeTabLocale branch December 17, 2024 09:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
PR-i18n For translations
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants