Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Render audio file in the files list and improve media viewer for audio/voice files #4031

Merged
merged 12 commits into from
Dec 13, 2024

Conversation

bmarty
Copy link
Member

@bmarty bmarty commented Dec 12, 2024

Content

Motivation and context

Part of the file gallery: audio files will be rendered in a different way than regular files.
This PR does not include an inline player from the file list.

This PR include an update of the file viewer for audio file. ExoPlayer is used to play the audio (voice message/audio files such as mp3). ExoPlayer can render artwork if available.

Screenshots / GIFs

AudioPlayer.mp4

Tests

  • Send voice message and audio files such as mp3 to a room
  • Open the media gallery
  • Open the audio file and play it directly from the app.

Tested devices

  • Physical
  • Emulator
  • OS version(s):

Checklist

@bmarty bmarty added the PR-Feature For a new feature label Dec 12, 2024
@bmarty bmarty requested a review from a team as a code owner December 12, 2024 17:22
@bmarty bmarty requested review from ganfra and removed request for a team December 12, 2024 17:22
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

taking the opportunity to improve this preview.

@bmarty
Copy link
Member Author

bmarty commented Dec 13, 2024

I think I need to propagate the "is VoiceMessage" info, I can not only rely on the presence of the waveform. I will rebase the branch and push a commit for this.

@bmarty bmarty force-pushed the feature/bma/fileListAudioPlayer branch from f235d07 to 54c2685 Compare December 13, 2024 10:54
Copy link
Contributor

github-actions bot commented Dec 13, 2024

📱 Scan the QR code below to install the build (arm64 only) for this PR.
QR code
If you can't scan the QR code you can install the build via this link: https://i.diawi.com/PTBoYF

Copy link

codecov bot commented Dec 13, 2024

Codecov Report

Attention: Patch coverage is 76.43443% with 115 lines in your changes missing coverage. Please review.

Project coverage is 82.99%. Comparing base (b2a9ebb) to head (b236389).
Report is 14 commits behind head on develop.

Files with missing lines Patch % Lines
...ies/mediaviewer/impl/local/audio/MediaAudioView.kt 70.10% 46 Missing and 9 partials ⚠️
...ries/mediaviewer/impl/local/audio/MediaMetadata.kt 0.00% 12 Missing and 2 partials ⚠️
...ies/mediaviewer/impl/local/video/MediaVideoView.kt 23.52% 13 Missing ⚠️
...diaviewer/impl/local/player/ExoPlayerExtensions.kt 0.00% 8 Missing ⚠️
...aries/mediaviewer/impl/gallery/MediaGalleryView.kt 28.57% 0 Missing and 5 partials ⚠️
...id/libraries/mediaviewer/impl/gallery/MediaItem.kt 58.33% 5 Missing ⚠️
.../mediaviewer/impl/local/player/ExoPlayerFactory.kt 28.57% 4 Missing and 1 partial ⚠️
...aries/mediaviewer/impl/gallery/EventItemFactory.kt 66.66% 0 Missing and 4 partials ⚠️
...aries/mediaviewer/impl/gallery/ui/AudioItemView.kt 96.15% 2 Missing and 2 partials ⚠️
...s/mediaviewer/impl/DefaultMediaViewerEntryPoint.kt 0.00% 1 Missing ⚠️
... and 1 more
Additional details and impacted files
@@             Coverage Diff             @@
##           develop    #4031      +/-   ##
===========================================
- Coverage    83.05%   82.99%   -0.06%     
===========================================
  Files         1856     1862       +6     
  Lines        48064    48499     +435     
  Branches      5646     5691      +45     
===========================================
+ Hits         39920    40254     +334     
- Misses        6145     6227      +82     
- Partials      1999     2018      +19     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@bmarty bmarty merged commit 2a3fd99 into develop Dec 13, 2024
24 of 26 checks passed
@bmarty bmarty deleted the feature/bma/fileListAudioPlayer branch December 13, 2024 16:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
PR-Feature For a new feature
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants