-
Notifications
You must be signed in to change notification settings - Fork 170
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Render audio file in the files list and improve media viewer for audio/voice files #4031
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
taking the opportunity to improve this preview.
I think I need to propagate the "is VoiceMessage" info, I can not only rely on the presence of the waveform. I will rebase the branch and push a commit for this. |
Make MediaPlayerControllerView compatible to control audio playback
… the embedded controller.
f235d07
to
54c2685
Compare
📱 Scan the QR code below to install the build (arm64 only) for this PR. |
Quality Gate passedIssues Measures |
Content
Motivation and context
Part of the file gallery: audio files will be rendered in a different way than regular files.
This PR does not include an inline player from the file list.
This PR include an update of the file viewer for audio file. ExoPlayer is used to play the audio (voice message/audio files such as mp3). ExoPlayer can render artwork if available.
Screenshots / GIFs
AudioPlayer.mp4
Tests
Tested devices
Checklist