Do not auto-play videos.

[bmarty]

Following what has been done on iOS and avoiding user to get loud audio when clicking on a video in the timeline, the application will not auto play video when open in full screen.

[ganfra]

How it wasn't necessary before?

[bmarty]

For the addListener, I feel better with having the parity onCreate/onDestroy.
For the prepare, if I do not call it onResume, we get on black screen when putting the app in bg then in fg, not sure why.

All is working fine when testing the player with this code.

[ganfra]

AddListener and dispose is not exactly parity I'd say?
But are we not already adding this listener somewhere else? that was my question

[bmarty]

The listener was set in a LaunchedEffect block (previous version line 132, see the diff)

[ganfra]

Ok, I didn't see it!

[github-actions]

📱 Scan the QR code below to install the build (arm64 only) for this PR.

If you can't scan the QR code you can install the build via this link: https://i.diawi.com/htbJiU

[sonarqubecloud]

Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

[codecov]

Codecov Report

Attention: Patch coverage is 37.50000% with 5 lines in your changes missing coverage. Please review.

Project coverage is 83.08%. Comparing base (b73884c) to head (1ee8676).
Report is 17 commits behind head on develop.

Files with missing lines	Patch %	Lines
...ies/mediaviewer/impl/local/video/MediaVideoView.kt	37.50%	5 Missing ⚠️

Additional details and impacted files

@@             Coverage Diff             @@
##           develop    #3978      +/-   ##
===========================================
+ Coverage    83.03%   83.08%   +0.04%     
===========================================
  Files         1796     1805       +9     
  Lines        45600    45638      +38     
  Branches      5375     5380       +5     
===========================================
+ Hits         37864    37918      +54     
+ Misses        5855     5833      -22     
- Partials      1881     1887       +6     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.