Insert a mention when clicking user's name in the timeline #3858
+98
−27
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Content
Clicking on a user's name in the timeline inserts a mention into the composer. Clicking on the avatar retains the old behaviour of opening the user details view.
Currently this doesn't work with the RTE due to some required changes in the RTE library that I haven't attempted yet.
One small "bug" is that the cursor is unconditionally jumped to the end of the text, not to the end of the mention (although the same happens when manually inserting a mention)
Motivation and context
By popular demand; also element-hq/element-x-ios#1527
This mirrors Element Android and Element Web behaviour.
Screenshots / GIFs
screen-20241112-124613.2.mp4
Tests
Tested devices
Checklist