Don't delete uploaded logs

[jmartinesp]

Content

Remove code in DefaultBugReporter that deleted all existing log files except for the most recent one.

Motivation and context

The log removal happened after the logs had been compressed but before we were sure they had reached their destination. Since Rust already takes care of the log roration there's no need for this code AFAICT, and it could cause accidental log data loss.

Tests

• Send a bug report.
• Send another or check the files in your device with adb.

The log files should be kept.

Tested devices

• Physical
• Emulator
• OS version(s): 14

Checklist

• Changes have been tested on an Android device or Android emulator with API 23
• UI change has been tested on both light and dark themes
• Accessibility has been taken into account. See https://github.com/element-hq/element-x-android/blob/develop/CONTRIBUTING.md#accessibility
• Pull request is based on the develop branch
• Pull request title will be used in the release note, it clearly define what will change for the user
• Pull request includes screenshots or videos if containing UI changes
• Pull request includes a sign off
• You've made a self review of your PR

[github-actions]

📱 Scan the QR code below to install the build (arm64 only) for this PR.

If you can't scan the QR code you can install the build via this link: https://i.diawi.com/hQoVBc

[codecov]

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 82.69%. Comparing base (3001efb) to head (1df46ff).
Report is 1 commits behind head on develop.

Additional details and impacted files

@@           Coverage Diff            @@
##           develop    #3540   +/-   ##
========================================
  Coverage    82.68%   82.69%           
========================================
  Files         1732     1732           
  Lines        40983    40977    -6     
  Branches      4966     4964    -2     
========================================
- Hits         33888    33887    -1     
+ Misses        5341     5337    -4     
+ Partials      1754     1753    -1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

[ganfra]

Are you sure rust sdk is cleaning them? At the time I implemented that it wasn't the case

[jmartinesp]

Are you sure rust sdk is cleaning them? At the time I implemented that it wasn't the case

It should be, we're internally using this:

Also, that was over a year ago, I think 😅 .

[ganfra]

Nice, what "n" are we using?

[jmartinesp]

Nice, what "n" are we using?

// Keep a maximum of 1 week of log files.
numberOfFiles = 7 * 24,

In any case, I'm testing this right now. But since new files are only written every hour, I need to wait for a bit 🫠 .

[jmartinesp]

In any case, I'm testing this right now.

Well, color me surprised, it doesn't, or not under some circumstances: I lowered the max value to 2 and I have still all my logs here.

[bmarty]

(We hold on until we are sure that the SDK is deleting the files during the rotation).

[jmartinesp]

matrix-org/matrix-rust-sdk#4038 is now merged, we'd need a new SDK version and we can both fix the bud and remove this code.

[jmartinesp]

We now have the right log rotation code since #3553.

[sonarqubecloud]

Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud

[jmartinesp]

I just re-tested this and I can confirm old logs are now being removed so this code is no longer needed.