Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix image viewer glitch #3537

Merged
merged 3 commits into from
Sep 26, 2024
Merged

Fix image viewer glitch #3537

merged 3 commits into from
Sep 26, 2024

Conversation

ganfra
Copy link
Member

@ganfra ganfra commented Sep 25, 2024

  • Fix glitch when transitioning from thumbnail to content
  • Open avatars using overlay mode instead of backstack

@ganfra ganfra added the PR-Misc For other changes label Sep 25, 2024
@ganfra ganfra marked this pull request as ready for review September 25, 2024 12:00
@ganfra ganfra requested a review from a team as a code owner September 25, 2024 12:00
@ganfra ganfra requested review from bmarty and removed request for a team September 25, 2024 12:00
Copy link
Contributor

github-actions bot commented Sep 25, 2024

📱 Scan the QR code below to install the build (arm64 only) for this PR.
QR code
If you can't scan the QR code you can install the build via this link: https://i.diawi.com/MPBqKi

Copy link

codecov bot commented Sep 25, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 82.72%. Comparing base (41126c7) to head (acae30b).
Report is 42 commits behind head on develop.

Additional details and impacted files
@@             Coverage Diff             @@
##           develop    #3537      +/-   ##
===========================================
+ Coverage    82.68%   82.72%   +0.03%     
===========================================
  Files         1732     1732              
  Lines        40904    40898       -6     
  Branches      4973     4973              
===========================================
+ Hits         33823    33833      +10     
+ Misses        5316     5304      -12     
+ Partials      1765     1761       -4     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@bmarty bmarty left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks. Tested OK. As a bonus I have fixed the 2 ignored tests on this View.

Copy link

@ganfra ganfra enabled auto-merge September 25, 2024 18:50
@ganfra ganfra added the Run-Maestro Starts a Maestro Cloud session to run integration tests label Sep 25, 2024
@github-actions github-actions bot removed the Run-Maestro Starts a Maestro Cloud session to run integration tests label Sep 25, 2024
@ganfra ganfra merged commit 71c0eb1 into develop Sep 26, 2024
30 checks passed
@ganfra ganfra deleted the feature/fga/fix_image_viewer_glitch branch September 26, 2024 09:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
PR-Misc For other changes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants