Fall back to initials avatar when image avatar doesn't work

[SpiritCroc]

Initially I had it implemented such that it would only fallback on error, but actually it's nice to have also while loading if it takes a while to load the avatar.

Type of change

• Feature
• Bugfix
• Technical
• Other :

Content

SubcomposeAsyncImage allows us to render the image or something else based on the render state, so we can render the initials avatar if the image doesn't load successfully

Motivation and context

I heard in the Element X chat that Element wants to have this (I had this in SchildiChat for a while already)

Screenshots / GIFs

Imagine some name-based fallback avatars in the roomlist like before, but also for contacts with broken mxc url

Tests

• Tell somebody you're chatting with to run /myroomavatar mxc://broken on desktop
• Observe their (lack of) avatar (before: would stay empty, now: falls back to initials avatar)

Tested devices

• Physical
• Emulator
• OS version(s):

Checklist

• Changes have been tested on an Android device or Android emulator with API 23
• UI change has been tested on both light and dark themes
• Accessibility has been taken into account. See https://github.com/element-hq/element-x-android/blob/develop/CONTRIBUTING.md#accessibility
• Pull request is based on the develop branch
• Pull request includes a new file under ./changelog.d. See https://github.com/element-hq/element-x-android/blob/develop/CONTRIBUTING.md#changelog
• Pull request includes screenshots or videos if containing UI changes
• Pull request includes a sign off
• You've made a self review of your PR

Sign-off

Signed-off-by: Tobias Büttner [email protected]

[github-actions]

Thank you for your contribution! Here are a few things to check in the PR to ensure it's reviewed as quickly as possible:

• Your branch should be based on origin/develop, at least when it was created.
• There is a changelog entry in the changelog.d folder with the Towncrier format.
• The test pass locally running ./gradlew test.
• The code quality check suite pass locally running ./gradlew runQualityChecks.
• If you modified anything related to the UI, including previews, you'll have to run the Record screenshots GH action in your forked repo: that will generate compatible new screenshots. However, given Github Actions limitations, it will prevent the CI from running temporarily, until you upload a new commit after that one. To do so, just pull the latest changes and push an empty commit.

[SpiritCroc]

I guess the debugPlaceholderAvatar I removed was necessary for the paparazzi tests, maybe someone else can look into that, not sure what the preferred approach here would be (generate new reference screenshots? change behaviour for the test case with something like LocalInspectionMode.current?)

[bmarty]

Thanks for the PR @SpiritCroc! Please see my answer about previews.

[codecov]

Codecov Report

Attention: Patch coverage is 80.00000% with 4 lines in your changes are missing coverage. Please review.

Project coverage is 73.48%. Comparing base (a46ff73) to head (e4b76e0).
Report is 6 commits behind head on develop.

Files	Patch %	Lines
...libraries/designsystem/components/avatar/Avatar.kt	80.00%	0 Missing and 4 partials ⚠️

Additional details and impacted files

@@             Coverage Diff             @@
##           develop    #2667      +/-   ##
===========================================
- Coverage    73.48%   73.48%   -0.01%     
===========================================
  Files         1456     1456              
  Lines        35113    35126      +13     
  Branches      6733     6738       +5     
===========================================
+ Hits         25804    25813       +9     
  Misses        5793     5793              
- Partials      3516     3520       +4     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

[bmarty]

Thanks for the update!