Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Mentions: Display mentions in replies #1456

Closed
Tracked by #2067
Velin92 opened this issue Sep 28, 2023 · 2 comments
Closed
Tracked by #2067

Mentions: Display mentions in replies #1456

Velin92 opened this issue Sep 28, 2023 · 2 comments
Labels
A-Pills A-Timeline T-Enhancement New features, changes in functionality, performance boosts, user-facing improvements

Comments

@Velin92
Copy link
Member

Velin92 commented Sep 28, 2023

From element-x-ios created by Velin92: element-hq/element-x-ios#1831

The mention should also be displayed in the timeline for replies, but not as a tappable link (since it should not override the reply tap behaviour).
@Velin92 Velin92 added A-Pills A-Timeline T-Enhancement New features, changes in functionality, performance boosts, user-facing improvements labels Sep 28, 2023
This was referenced Sep 28, 2023
Closed
Closed
@Velin92
Copy link
Member Author

Velin92 commented Oct 2, 2023 •
edited
Loading

Blocked as we are waiting product feedback if we actually really want to display mentions as pills in replies or only as simple plain text

@jmartinesp
Copy link
Member

Since we just decided to display these as plain text mentions (something like Hey @Jorge!) I believe this was completed by #1850

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
A-Pills A-Timeline T-Enhancement New features, changes in functionality, performance boosts, user-facing improvements
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@jmartinesp @Velin92