Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Story] Reply to a message that contains a mention #2067

Closed
4 tasks done
VolkerJunginger opened this issue Sep 22, 2023 · 7 comments
Closed
4 tasks done

[Story] Reply to a message that contains a mention #2067

VolkerJunginger opened this issue Sep 22, 2023 · 7 comments

Comments

@VolkerJunginger
Copy link
Contributor

VolkerJunginger commented Sep 22, 2023

Story

As a user I want to be able to reply to a message that contains a mention.

Figma link: TBD

Acceptance criteria

  • The design of the reply could take the mention into account.
  • The reply should not to trigger notifications or badges for the mentioned user. (the user has already been mentioned for that message)
  • The user can add an additional mention to their message

Size estimate

S

Open questions

Tasks

Subtasks

Android

  1. A-Pills A-Timeline T-Enhancement

iOS

  1. A-Pills A-Timeline T-Enhancement

Rust

  1. A-Notification A-Room-List A-Timeline X-Needs-Rust Z-Schedule
    Velin92
  • QA signoff on completion
  • Design signoff on completion
  • Product signoff on completion
@manuroe
Copy link
Member

manuroe commented Sep 22, 2023

The reply should not to trigger notifications or badges for the mentioned user is not aligned with MSC3952 that states Clients should include the sender of the event being replied to as well as any mentioned users in that event (excluding yourself)

@VolkerJunginger can you align with @daniellekirkwood on this acceptance criteria. Web and mobiles must have the same behavior.

@clokep
Copy link
Contributor

clokep commented Sep 22, 2023

@VolkerJunginger can you align with @daniellekirkwood on this acceptance criteria. Web and mobiles must have the same behavior.

I think MSC3952 was mostly designed to not change behavior. The behavior of the legacy mentions was that both the sender of the original message and the mentioned user in it would end up in the "fallback" text causing both to be mentioned.

Luckily MSC3952 makes it so you can control the fallback separately from who is mentioned, so this is actually controllable now.

@manuroe
Copy link
Member

manuroe commented Sep 22, 2023

Thanks @clokep. This is great. This is then a product decision to make the break with legacy apps or other matrix clients.

@VolkerJunginger the thing to get here is this is the sender app that decides the people to mention. EX can send mentions as you describe but there will no way to prevent a different behavior from messages coming another matrix client.

@Velin92
Copy link
Member

Velin92 commented Sep 28, 2023

Thanks @clokep. This is great. This is then a product decision to make the break with legacy apps or other matrix clients.

@VolkerJunginger the thing to get here is this is the sender app that decides the people to mention. EX can send mentions as you describe but there will no way to prevent a different behavior from messages coming another matrix client.

according to @jplatte the intentional mention task can allow us to not to trigger notifications or badges for the mentioned user

@jplatte
Copy link

jplatte commented Sep 28, 2023

Just to be clear, intentional mentions help when the client that sends the reply implements them. The problem will persist for messages received by EX that are sent by clients that don't implement intentional mentions. (what Manu said above)

@VolkerJunginger
Copy link
Contributor Author

Thanks @clokep. This is great. This is then a product decision to make the break with legacy apps or other matrix clients.

@VolkerJunginger the thing to get here is this is the sender app that decides the people to mention. EX can send mentions as you describe but there will no way to prevent a different behavior from messages coming another matrix client.

that's ok.

@Velin92
Copy link
Member

Velin92 commented Oct 2, 2023

Blocking element-hq/element-x-android#1456 and element-hq/element-x-ios#1831 since we need to decide if we want or not to display mentions as pills inside replies.
@callumu @VolkerJunginger

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

6 participants