-
-
Notifications
You must be signed in to change notification settings - Fork 2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Increased the emoji size to 2em #3642
Conversation
Between #2890 (comment) and #3642 (comment) it looks like it should be increased, the amount by which though needs deciding - @ara4n / @lampholder any comments on this? |
can we get this merged/done? please? |
@lampholder, I think it would be good to identify someone who can take a decision here. The general idea seems to have support, but we need to find the precise value to use. Should the decision maker be UX or someone else? |
/me raises it with the product team (sorry for glacial progress) |
And we have a conclusion! The delay was in me typing the conclusion in here btw - Matthew and Amandine responded right away. The conclusion is: if it doesn't affect line spacing then go for it; if lines with emoji end up vertically wider (taller?) than lines without then nooooooo. Our lines look like they could accommodate a 1.2 em emoji without altering spacing - what does a 2em emoji do? |
I would suggest changing the emoji size to |
It looks like the file this needs has changed repos. Switching to pixels as @jryans mentions sounds like a good idea, Provided @lampholder's comment is addressed, I would see no problem with merging this over on the react-sdk side. |
Fixes #2890
Its a good idea to make the emojis look more visible and vibrant. Having them on the same size as the text makes them look very small. The one very good reason to have a bigger emoji is that an emoji expresents an expression which definitely conveys information more than one ASCII character.