Skip to content

Fix room list menu flashes when menu is closed #31868

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
florianduros merged 2 commits into from
Jan 26, 2026
Merged

Fix room list menu flashes when menu is closed #31868

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
86b2b2b
chore: update compound to `8.3.6`
florianduros Jan 23, 2026
43d0a67
chore: update snapshots
florianduros Jan 23, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -94,7 +94,7 @@
"@sentry/browser": "^10.0.0",
"@types/png-chunks-extract": "^1.0.2",
"@vector-im/compound-design-tokens": "6.8.0",
"@vector-im/compound-web": "^8.3.5",
"@vector-im/compound-web": "^8.3.6",
"@vector-im/matrix-wysiwyg": "2.40.0",
"@zxcvbn-ts/core": "^3.0.4",
"@zxcvbn-ts/language-common": "^3.0.4",
Expand Down
2 changes: 1 addition & 1 deletion packages/shared-components/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -83,7 +83,7 @@
"@types/react-dom": "^19.2.3",
"@typescript-eslint/eslint-plugin": "^8.53.1",
"@typescript-eslint/parser": "^8.53.1",
"@vector-im/compound-web": "^8.3.5",
"@vector-im/compound-web": "^8.3.6",
"@vitejs/plugin-react": "^5.1.2",
"@vitest/browser-playwright": "^4.0.17",
"@vitest/coverage-v8": "^4.0.17",
Expand Down
8 changes: 4 additions & 4 deletions packages/shared-components/yarn.lock
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1740,10 +1740,10 @@
resolved "https://registry.yarnpkg.com/@vector-im/compound-design-tokens/-/compound-design-tokens-6.8.0.tgz#3711df7b22a065c4d49dedbd8b83241c73a619f9"
integrity sha512-RDJjnFg9yxkbSYqiAG5Nv4enD5h8Oq89su0izZIvuKRzBxLWkV2/+JoDM94zkjI4aDLYff3gwWMviqAxJKi+Lw==

"@vector-im/compound-web@^8.3.5":
version "8.3.5"
resolved "https://registry.yarnpkg.com/@vector-im/compound-web/-/compound-web-8.3.5.tgz#bb6d712868915899978128c2081b7b09389a1570"
integrity sha512-MbqnZMSwu3y8Z7b529Hf8t790adbcjQiq6X+PrX8emvRDsQsSa/S5Na1udStseCuLp3nAfqrgnospIgselbpvA==
"@vector-im/compound-web@^8.3.6":
version "8.3.6"
resolved "https://registry.yarnpkg.com/@vector-im/compound-web/-/compound-web-8.3.6.tgz#1f669e339d086faa14f4cd9f7a39e7d3d3e2a4d1"
integrity sha512-w7jjUJ8dXlLE2Ja/2J8Z433mtra3QF0cHDU5BGVLBBJnT/IwU4vazJRaU61dIOm3OnzDnsDreKcrMtWAUIhQkA==
dependencies:
"@floating-ui/react" "^0.27.0"
"@radix-ui/react-context-menu" "^2.2.16"
Expand Down
48 changes: 24 additions & 24 deletions test/unit-tests/components/structures/__snapshots__/SpaceHierarchy-test.tsx.snap
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -131,18 +131,18 @@ exports[`SpaceHierarchy <SpaceHierarchy /> renders 1`] = `
class="_inline-field-control_19upo_44"
>
<div
class="_container_1md5v_10"
class="_container_153f2_10"
>
<input
aria-labelledby="_r_8_"
class="_input_1md5v_18"
class="_input_153f2_18"
id="checkbox_MwbPDmfGtm"
role="presentation"
tabindex="-1"
type="checkbox"
/>
<div
class="_ui_1md5v_19"
class="_ui_153f2_19"
>
<svg
aria-hidden="true"
Expand Down Expand Up @@ -229,18 +229,18 @@ exports[`SpaceHierarchy <SpaceHierarchy /> renders 1`] = `
class="_inline-field-control_19upo_44"
>
<div
class="_container_1md5v_10"
class="_container_153f2_10"
>
<input
aria-labelledby="_r_c_"
class="_input_1md5v_18"
class="_input_153f2_18"
id="checkbox_GQvdMWe954"
role="presentation"
tabindex="-1"
type="checkbox"
/>
<div
class="_ui_1md5v_19"
class="_ui_153f2_19"
>
<svg
aria-hidden="true"
Expand Down Expand Up @@ -328,18 +328,18 @@ exports[`SpaceHierarchy <SpaceHierarchy /> renders 1`] = `
class="_inline-field-control_19upo_44"
>
<div
class="_container_1md5v_10"
class="_container_153f2_10"
>
<input
aria-labelledby="_r_g_"
class="_input_1md5v_18"
class="_input_153f2_18"
id="checkbox_DVIAu5CsiH"
role="presentation"
tabindex="-1"
type="checkbox"
/>
<div
class="_ui_1md5v_19"
class="_ui_153f2_19"
>
<svg
aria-hidden="true"
Expand Down Expand Up @@ -449,19 +449,19 @@ exports[`SpaceHierarchy <SpaceHierarchy /> renders 1`] = `
class="_inline-field-control_19upo_44"
>
<div
class="_container_1md5v_10"
class="_container_153f2_10"
>
<input
aria-labelledby="_r_k_"
class="_input_1md5v_18"
class="_input_153f2_18"
disabled=""
id="checkbox_RD7nyrA2oh"
role="presentation"
tabindex="-1"
type="checkbox"
/>
<div
class="_ui_1md5v_19"
class="_ui_153f2_19"
>
<svg
aria-hidden="true"
Expand Down Expand Up @@ -549,18 +549,18 @@ exports[`SpaceHierarchy <SpaceHierarchy /> renders 1`] = `
class="_inline-field-control_19upo_44"
>
<div
class="_container_1md5v_10"
class="_container_153f2_10"
>
<input
aria-labelledby="_r_t_"
class="_input_1md5v_18"
class="_input_153f2_18"
id="checkbox_jWVJIPauy1"
role="presentation"
tabindex="-1"
type="checkbox"
/>
<div
class="_ui_1md5v_19"
class="_ui_153f2_19"
>
<svg
aria-hidden="true"
Expand Down Expand Up @@ -720,18 +720,18 @@ exports[`SpaceHierarchy <SpaceHierarchy /> should not render cycles 1`] = `
class="_inline-field-control_19upo_44"
>
<div
class="_container_1md5v_10"
class="_container_153f2_10"
>
<input
aria-labelledby="_r_3i_"
class="_input_1md5v_18"
class="_input_153f2_18"
id="checkbox_EetmBG4yVC"
role="presentation"
tabindex="-1"
type="checkbox"
/>
<div
class="_ui_1md5v_19"
class="_ui_153f2_19"
>
<svg
aria-hidden="true"
Expand Down Expand Up @@ -818,18 +818,18 @@ exports[`SpaceHierarchy <SpaceHierarchy /> should not render cycles 1`] = `
class="_inline-field-control_19upo_44"
>
<div
class="_container_1md5v_10"
class="_container_153f2_10"
>
<input
aria-labelledby="_r_3m_"
class="_input_1md5v_18"
class="_input_153f2_18"
id="checkbox_eEefiPqpMR"
role="presentation"
tabindex="-1"
type="checkbox"
/>
<div
class="_ui_1md5v_19"
class="_ui_153f2_19"
>
<svg
aria-hidden="true"
Expand Down Expand Up @@ -917,18 +917,18 @@ exports[`SpaceHierarchy <SpaceHierarchy /> should not render cycles 1`] = `
class="_inline-field-control_19upo_44"
>
<div
class="_container_1md5v_10"
class="_container_153f2_10"
>
<input
aria-labelledby="_r_3q_"
class="_input_1md5v_18"
class="_input_153f2_18"
id="checkbox_MwbPDmfGtm"
role="presentation"
tabindex="-1"
type="checkbox"
/>
<div
class="_ui_1md5v_19"
class="_ui_153f2_19"
>
<svg
aria-hidden="true"
Expand Down
6 changes: 3 additions & 3 deletions test/unit-tests/components/views/dialogs/__snapshots__/ExportDialog-test.tsx.snap
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -173,15 +173,15 @@ exports[`<ExportDialog /> renders export dialog 1`] = `
class="_inline-field-control_19upo_44"
>
<div
class="_container_1md5v_10"
class="_container_153f2_10"
>
<input
class="_input_1md5v_18"
class="_input_153f2_18"
id="include-attachments"
type="checkbox"
/>
<div
class="_ui_1md5v_19"
class="_ui_153f2_19"
>
<svg
aria-hidden="true"
Expand Down
6 changes: 3 additions & 3 deletions ...tests/components/views/dialogs/__snapshots__/ManageRestrictedJoinRuleDialog-test.tsx.snap
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -85,16 +85,16 @@ exports[`<ManageRestrictedJoinRuleDialog /> should list spaces which are not par
class="_inline-field-control_19upo_44"
>
<div
class="_container_1md5v_10"
class="_container_153f2_10"
>
<input
aria-describedby="_r_5_"
class="_input_1md5v_18"
class="_input_153f2_18"
id="checkbox_vY7Q4uEh9K"
type="checkbox"
/>
<div
class="_ui_1md5v_19"
class="_ui_153f2_19"
>
<svg
aria-hidden="true"
Expand Down
12 changes: 6 additions & 6 deletions test/unit-tests/components/views/dialogs/__snapshots__/ShareDialog-test.tsx.snap
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -316,15 +316,15 @@ exports[`ShareDialog should render a share dialog for a matrix event 1`] = `
</div>
<label>
<div
class="_container_1md5v_10"
class="_container_153f2_10"
>
<input
checked=""
class="_input_1md5v_18"
class="_input_153f2_18"
type="checkbox"
/>
<div
class="_ui_1md5v_19"
class="_ui_153f2_19"
>
<svg
aria-hidden="true"
Expand Down Expand Up @@ -513,14 +513,14 @@ exports[`ShareDialog should render a share dialog for a room 1`] = `
</div>
<label>
<div
class="_container_1md5v_10"
class="_container_153f2_10"
>
<input
class="_input_1md5v_18"
class="_input_153f2_18"
type="checkbox"
/>
<div
class="_ui_1md5v_19"
class="_ui_153f2_19"
>
<svg
aria-hidden="true"
Expand Down
12 changes: 6 additions & 6 deletions test/unit-tests/components/views/elements/__snapshots__/LabelledCheckbox-test.tsx.snap
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -15,17 +15,17 @@ exports[`<LabelledCheckbox /> should render with byline of "this is a byline" 1`
class="_inline-field-control_19upo_44"
>
<div
class="_container_1md5v_10"
class="_container_153f2_10"
>
<input
aria-describedby="_r_4_"
checked=""
class="_input_1md5v_18"
class="_input_153f2_18"
id="checkbox_vY7Q4uEh9K"
type="checkbox"
/>
<div
class="_ui_1md5v_19"
class="_ui_153f2_19"
>
<svg
aria-hidden="true"
Expand Down Expand Up @@ -83,16 +83,16 @@ exports[`<LabelledCheckbox /> should render with byline of undefined 1`] = `
class="_inline-field-control_19upo_44"
>
<div
class="_container_1md5v_10"
class="_container_153f2_10"
>
<input
checked=""
class="_input_1md5v_18"
class="_input_153f2_18"
id="checkbox_vY7Q4uEh9K"
type="checkbox"
/>
<div
class="_ui_1md5v_19"
class="_ui_153f2_19"
>
<svg
aria-hidden="true"
Expand Down
4 changes: 2 additions & 2 deletions test/unit-tests/components/views/rooms/__snapshots__/PinnedEventTile-test.tsx.snap
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -189,7 +189,7 @@ exports[`<PinnedEventTile /> should render the menu with all the options 1`] = `
aria-label="Open menu"
aria-labelledby="radix-_r_14_"
aria-orientation="vertical"
class="_menu_1glhz_8"
class="_menu_1w1u7_8"
data-align="start"
data-orientation="vertical"
data-radix-menu-content=""
Expand Down Expand Up @@ -380,7 +380,7 @@ exports[`<PinnedEventTile /> should render the menu without unpin and delete 1`]
aria-label="Open menu"
aria-labelledby="radix-_r_o_"
aria-orientation="vertical"
class="_menu_1glhz_8"
class="_menu_1w1u7_8"
data-align="start"
data-orientation="vertical"
data-radix-menu-content=""
Expand Down
Loading
Loading