Show "Bob shared this message" on messages shared via MSC4268 #31684
Conversation
richvdh
force-pushed
the
rav/message_shared_info
branch
from
12257e4 to
bdfb5cb
Compare
If we received the keys for a given message from another user, indicate that in the timeline, rather than just saying "authenticity not guaranteed"
richvdh
force-pushed
the
rav/message_shared_info
branch
from
bdfb5cb to
bf1c8d0
Compare
| * A small icon with tooltip, used in the left margin of an {@link EventTile}, which indicates a problem | ||
| * with an encrypted event. | ||
| */ | ||
| export function E2ePadlock(props: IE2ePadlockProps): ReactNode { |
There was a problem hiding this comment.
A reason to not put this component in shared component as a simple component (without MVVM)?
There was a problem hiding this comment.
What's the advantage to making it a shared component? (Shared with what?) Seems like it's more stuff that I need to change.
There was a problem hiding this comment.
To be able to use it in Aurora or in a EW modules. The advantage is to be able to use storybook on it and to benefit the story screenshot tests too
There was a problem hiding this comment.
I had a go at this, but couldn't figure out how to rebuild the shared components. Documentation seems a little lacking about how to build and maintain the shared components, making it hard for contributors outside the core Web team to get started here.
There was a problem hiding this comment.
I added documentation to the shared components. Can you give it a second chance?
There was a problem hiding this comment.
OK, done. PTAL.
... and reverted, due to the problems with tabIndex, discussed in another thread.
test/unit-tests/components/views/rooms/EventTile/E2eMessageSharedIcon-test.tsx
Show resolved
Hide resolved
test/unit-tests/components/views/rooms/EventTile/E2eMessageSharedIcon-test.tsx
Show resolved
Hide resolved
Co-authored-by: Florian Duros <[email protected]>
* Factor out E2ePadlock to its own file * Show "Bob shared this message" on messages shared via MSC4268 If we received the keys for a given message from another user, indicate that in the timeline, rather than just saying "authenticity not guaranteed" * Apply suggestions from code review Co-authored-by: Florian Duros <[email protected]> * Address review comments * Move E2ePadlock to shared-components * update snapshots * Revert "update snapshots" This reverts commit 751e31f. * Revert "Move E2ePadlock to shared-components" This reverts commit 172ef9f. --------- Co-authored-by: Florian Duros <[email protected]>
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
😬 |
If we received the keys for a given message from another user, indicate that in the timeline, rather than just saying "authenticity not guaranteed".
Screenshot:
As part of this, I've factored E2ePadlock out to its own file.
Builds on functionality added in matrix-org/matrix-js-sdk#5128.
Part of element-hq/element-meta#2877