Skip to content

Conversation

@lukas-runge
Copy link

@lukas-runge lukas-runge commented Jan 4, 2026

fixes #31628

Notes: fix user registration resulting in firewall bans on homeservers (#31628)

Checklist

@lukas-runge lukas-runge requested a review from a team as a code owner January 4, 2026 16:25
@lukas-runge lukas-runge requested a review from t3chguy January 4, 2026 16:26
@CLAassistant
Copy link

CLAassistant commented Jan 4, 2026

CLA assistant check
All committers have signed the CLA.

@github-actions github-actions bot added the Z-Community-PR Issue is solved by a community member's PR label Jan 4, 2026
Copy link
Member

@t3chguy t3chguy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Polling is required for certain registration UIA flows, like e-mail verification, msisdn verification, terms acceptance, and likely any unspecified flows (given they can be extended with custom flows by the server) - how does this not prevent that from working? Tests would be required to assert no registration flows are broken for this to be removed.

@t3chguy
Copy link
Member

t3chguy commented Jan 5, 2026

Worth also noting the poll prop predates the community-contributed registration token support (by multiple years)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Z-Community-PR Issue is solved by a community member's PR

Projects

None yet

Development

Successfully merging this pull request may close these issues.

🐛 polling in registration flow leads to firewall bans on homeservers

3 participants