Skip to content

Fix sort order in space hierarchy #30975

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 6 commits into
base: develop
Choose a base branch
from
Open

Fix sort order in space hierarchy #30975

wants to merge 6 commits into from

Conversation

t3chguy
Copy link
Member

@t3chguy t3chguy commented Oct 8, 2025 •
edited
Loading

To match spec & EX

@t3chguy
Fix sort order in space hierarchy
8fbd3bd 
To match spec and not add unexpected sorting by space vs room
@t3chguy
Iterate
41dc604 
Signed-off-by: Michael Telatynski <[email protected]>
@t3chguy
Update snapshot
d96c5e6 
Signed-off-by: Michael Telatynski <[email protected]>
@t3chguy
Add test
aa4908d 
Signed-off-by: Michael Telatynski <[email protected]>
@t3chguy
Update snapshot
817c4a5 
Signed-off-by: Michael Telatynski <[email protected]>
@t3chguy t3chguy marked this pull request as ready for review October 9, 2025 08:37
@t3chguy t3chguy requested a review from a team as a code owner October 9, 2025 08:37
@t3chguy t3chguy self-assigned this Oct 9, 2025
florianduros
florianduros reviewed Oct 9, 2025
View reviewed changes
Copy link
Member

@florianduros florianduros left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you give more information about the sort order. What was the previous space order and what is the new one?

@t3chguy
Copy link
Member Author

t3chguy commented Oct 9, 2025

Previous order matched the spec except it always listed rooms first then subspaces, which caused things to jump around as /hierarchy paginated and found rooms which would be inserted earlier in the sort order

New sort order just removes the rooms/subspaces split and lists them in the spec-defined order which matches /hierarchy and matches EX

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@florianduros florianduros florianduros left review comments

@MidhunSureshR MidhunSureshR Awaiting requested review from MidhunSureshR MidhunSureshR is a code owner automatically assigned from element-hq/element-web-reviewers

At least 1 approving review is required to merge this pull request.

Assignees

@t3chguy t3chguy

Labels

T-Defect

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@t3chguy @florianduros