Skip to content

Force preload to be false when setting an intent on an Element Call. #30759

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Sep 15, 2025
Merged

Force preload to be false when setting an intent on an Element Call. #30759

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
23e3410
force preload
Half-Shot Sep 15, 2025
9c63457
lnt
Half-Shot Sep 15, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 7 additions & 0 deletions src/models/Call.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -595,19 +595,26 @@ export class ElementCall extends Call {
const isDM = !!DMRoomMap.shared().getUserIdForRoomId(room.roomId);
const oldestCallMember = client.matrixRTC.getRoomSession(room).getOldestMembership();
const hasCallStarted = !!oldestCallMember && oldestCallMember.sender !== client.getSafeUserId();
// XXX: @element-hq/element-call-embedded <= 0.15.0 sets the wrong parameter for
// preload by default so we override here. This can be removed when that package
// is released and upgraded.
if (isDM) {
params.append("sendNotificationType", "ring");
if (hasCallStarted) {
params.append("intent", ElementCallIntent.JoinExistingDM);
params.append("preload", "false");
} else {
params.append("intent", ElementCallIntent.StartCallDM);
params.append("preload", "false");
}
} else {
params.append("sendNotificationType", "notification");
if (hasCallStarted) {
params.append("intent", ElementCallIntent.JoinExisting);
params.append("preload", "false");
} else {
params.append("intent", ElementCallIntent.StartCall);
params.append("preload", "false");
}
Comment on lines 601 to 618
Copy link
Contributor

@toger5 toger5 Sep 15, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If we touch this again anyways i think can change it to

if(isDM && hasCallStarted)
if(!isDM && hasCallStarted)
if(isDM && !hasCallStarted)
if(!isDM && !hasCallStarted)

I stumbled over the nesting again. I expect it to be more complicated than it is with the nesting. I know that params.append("sendNotificationType", "notification"); would then be duplicated but even that makes it more readable imo.

}
}
Expand Down
Loading