Skip to content

Fix flakey e2e test: should select the next unread room - #30634

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Aug 27, 2025
Merged

Fix flakey e2e test: should select the next unread room - #30634

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions playwright/e2e/left-panel/room-list-panel/room-list.spec.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -164,7 +164,7 @@
await roomListView.getByRole("option", { name: "Open room room29" }).click();
await page.keyboard.press("Alt+ArrowDown");

await expect(page.getByRole("heading", { name: "room28", level: 1 })).toBeVisible();

Check failure on line 167 in playwright/e2e/left-panel/room-list-panel/room-list.spec.ts

View workflow job for this annotation

GitHub Actions / Run Tests [Chrome] 2/6

[Chrome] › playwright/e2e/left-panel/room-list-panel/room-list.spec.ts:162:17 › Room list › Room list › Shortcuts › should select the next room 

  1) [Chrome] › playwright/e2e/left-panel/room-list-panel/room-list.spec.ts:162:17 › Room list › Room list › Shortcuts › should select the next room 
    Error: Timed out 5000ms waiting for expect(locator).toBeVisible()

    Locator: getByRole('heading', { name: 'room28', level: 1 })
    Expected: visible
    Received: <element(s) not found>
    Call log:
      - Expect "toBeVisible" with timeout 5000ms
      - waiting for getByRole('heading', { name: 'room28', level: 1 })


      165 |                 await page.keyboard.press("Alt+ArrowDown");
      166 |
    > 167 |                 await expect(page.getByRole("heading", { name: "room28", level: 1 })).toBeVisible();
          |                                                                                       ^
      168 |             });
      169 |
      170 |             test("should select the previous room", async ({ page, app, user }) => {
        at /home/runner/work/element-web/element-web/playwright/e2e/left-panel/room-list-panel/room-list.spec.ts:167:87
});

test("should select the previous room", async ({ page, app, user }) => {
Expand All @@ -172,7 +172,7 @@
await roomListView.getByRole("option", { name: "Open room room28" }).click();
await page.keyboard.press("Alt+ArrowUp");

await expect(page.getByRole("heading", { name: "room29", level: 1 })).toBeVisible();

Check failure on line 175 in playwright/e2e/left-panel/room-list-panel/room-list.spec.ts

View workflow job for this annotation

GitHub Actions / Run Tests [Chrome] 2/6

[Chrome] › playwright/e2e/left-panel/room-list-panel/room-list.spec.ts:170:17 › Room list › Room list › Shortcuts › should select the previous room 

  2) [Chrome] › playwright/e2e/left-panel/room-list-panel/room-list.spec.ts:170:17 › Room list › Room list › Shortcuts › should select the previous room 
    Error: Timed out 5000ms waiting for expect(locator).toBeVisible()

    Locator: getByRole('heading', { name: 'room29', level: 1 })
    Expected: visible
    Received: <element(s) not found>
    Call log:
      - Expect "toBeVisible" with timeout 5000ms
      - waiting for getByRole('heading', { name: 'room29', level: 1 })


      173 |                 await page.keyboard.press("Alt+ArrowUp");
      174 |
    > 175 |                 await expect(page.getByRole("heading", { name: "room29", level: 1 })).toBeVisible();
          |                                                                                       ^
      176 |             });
      177 |
      178 |             test("should select the last room", async ({ page, app, user }) => {
        at /home/runner/work/element-web/element-web/playwright/e2e/left-panel/room-list-panel/room-list.spec.ts:175:87
});

test("should select the last room", async ({ page, app, user }) => {
Expand All @@ -180,7 +180,7 @@
await roomListView.getByRole("option", { name: "Open room room29" }).click();
await page.keyboard.press("Alt+ArrowUp");

await expect(page.getByRole("heading", { name: "room0", level: 1 })).toBeVisible();

Check failure on line 183 in playwright/e2e/left-panel/room-list-panel/room-list.spec.ts

View workflow job for this annotation

GitHub Actions / Run Tests [Chrome] 2/6

[Chrome] › playwright/e2e/left-panel/room-list-panel/room-list.spec.ts:178:17 › Room list › Room list › Shortcuts › should select the last room 

  3) [Chrome] › playwright/e2e/left-panel/room-list-panel/room-list.spec.ts:178:17 › Room list › Room list › Shortcuts › should select the last room 
    Error: Timed out 5000ms waiting for expect(locator).toBeVisible()

    Locator: getByRole('heading', { name: 'room0', level: 1 })
    Expected: visible
    Received: <element(s) not found>
    Call log:
      - Expect "toBeVisible" with timeout 5000ms
      - waiting for getByRole('heading', { name: 'room0', level: 1 })


      181 |                 await page.keyboard.press("Alt+ArrowUp");
      182 |
    > 183 |                 await expect(page.getByRole("heading", { name: "room0", level: 1 })).toBeVisible();
          |                                                                                      ^
      184 |             });
      185 |
      186 |             test("should select the next unread room", async ({ page, app, user, bot }) => {
        at /home/runner/work/element-web/element-web/playwright/e2e/left-panel/room-list-panel/room-list.spec.ts:183:86
});

test("should select the next unread room", async ({ page, app, user, bot }) => {
Expand All @@ -193,6 +193,9 @@

await roomListView.getByRole("option", { name: "Open room room20" }).click();

// Make sure the room with the unread is visible before we press the keyboard action to select it
await expect(roomListView.getByRole("option", { name: "1 notification" })).toBeVisible();

await page.keyboard.press("Alt+Shift+ArrowDown");

await expect(page.getByRole("heading", { name: "1 notification", level: 1 })).toBeVisible();
Expand Down
Loading