Show a blue lock for unencrypted rooms and hide the grey shield for encrypted rooms #30440

langleyd · 2025-07-30T17:54:28Z

Related to #29425

…eyd/update_composer_encrpytion_icon

t3chguy · 2025-08-08T10:03:50Z

playwright/snapshots/polls/polls.spec.ts/ThreadView-with-a-poll-on-bubble-layout-linux.png

Lack of ellipsis here isn't great, makes it look broken. Not a new issue though

Hrmm the problem here is that it's a contenteditable div, so we are adding the placeholder text ourself in the css.
We do this by setting width and height to 0 and overflow: visible, so that the cursor is on the left of the placeholder, rather than pushed to the end.

This is then incompatible with getting the ellipsis to work. Not sure I see an alternative path forward.

t3chguy · 2025-08-08T10:07:33Z

src/components/views/rooms/wysiwyg_composer/SendWysiwygComposer.tsx

+            />
+        );
+    } else if (e2eStatus !== E2EStatus.Normal) {
+        leftIcon = <E2EIcon data-testid="wysiwyg-composer-left-icon" status={e2eStatus} />;


Surprised TS allows this data- attribute with the Props type the way it is

t3chguy · 2025-08-08T10:08:28Z

src/components/views/rooms/E2EIcon.tsx

    hideTooltip,
    tooltipPlacement,
    bordered,
+    ...props


A comment explaining which component gets the stray props would be good, also a bit confusing when there are no stray props in the Props type

…:vector-im/element-web into langleyd/update_composer_encrpytion_icon

igorgterra · 2025-08-27T16:19:03Z

As previously demonstrated, it's plausible for some use cases to have the homeserver set up without encryption. In this new version of Element, dated August 27, 2025, this became very invasive in chats, as in addition to the blue padlock icon, a giant message appears stating that it's not encrypted.

I thought it was a poor move. Things should be subtle for a wide range of uses.

xfst14 · 2025-08-28T13:50:56Z

As previously demonstrated, it's plausible for some use cases to have the homeserver set up without encryption. In this new version of Element, dated August 27, 2025, this became very invasive in chats, as in addition to the blue padlock icon, a giant message appears stating that it's not encrypted.

I thought it was a poor move. Things should be subtle for a wide range of uses.

we agree! this blue padlock icon should never have been put in the first place.

@andybalaam

https://build.opensuse.org/request/show/1302166 by user dheidler + anag_factory - Version 1.11.110 ## ✨ Features * Hide recovery key when re-entering it while creating or changing it (element-hq/element-web#30499). Contributed by @andybalaam. * Add `?no_universal_links=true` to OIDC url so EX doesn't try to handle it (element-hq/element-web#29439). Contributed by @t3chguy. * Show a blue lock for unencrypted rooms and hide the grey shield for encrypted rooms (element-hq/element-web#30440). Contributed by @langleyd. * Add support for Module API 1.4 (element-hq/element-web#30185). Contributed by @t3chguy. * MVVM - Introduce some helpers for snapshot management (element-hq/element-web#30398). Contributed by @MidhunSureshR. ## 🐛 Bug Fixes *

@andybalaam

https://build.opensuse.org/request/show/1302167 by user dheidler + anag_factory - Version 1.11.110 ## ✨ Features * Hide recovery key when re-entering it while creating or changing it (element-hq/element-web#30499). Contributed by @andybalaam. * Add `?no_universal_links=true` to OIDC url so EX doesn't try to handle it (element-hq/element-web#29439). Contributed by @t3chguy. * Show a blue lock for unencrypted rooms and hide the grey shield for encrypted rooms (element-hq/element-web#30440). Contributed by @langleyd. * Add support for Module API 1.4 (element-hq/element-web#30185). Contributed by @t3chguy. * MVVM - Introduce some helpers for snapshot management (element-hq/element-web#30398). Contributed by @MidhunSureshR. ## 🐛 Bug Fixes *

@andybalaam

Changes in [1.11.110](https://github.com/element-hq/element-web/releases/tag/v1.11.110) (2025-08-27) ==================================================================================================== * Hide recovery key when re-entering it while creating or changing it ([#30499](element-hq/element-web#30499)). Contributed by @andybalaam. * Add `?no_universal_links=true` to OIDC url so EX doesn't try to handle it ([#29439](element-hq/element-web#29439)). Contributed by @t3chguy. * Show a blue lock for unencrypted rooms and hide the grey shield for encrypted rooms ([#30440](element-hq/element-web#30440)). Contributed by @langleyd. * Add support for Module API 1.4 ([#30185](element-hq/element-web#30185)). Contributed by @t3chguy. * MVVM - Introduce some helpers for snapshot management ([#30398](element-hq/element-web#30398)). Contributed by @MidhunSureshR. * A11y: move focus to right panel when opened ([#30553](element-hq/element-web#30553)). Contributed by @florianduros. * Fix e2e warning icon should be white ([#30539](element-hq/element-web#30539)). Contributed by @florianduros. * Remove NoOneHere disabled reason. ([#30524](element-hq/element-web#30524)). Contributed by @toger5. * Fix downloading files with authenticated media API ([#30520](element-hq/element-web#30520)). Contributed by @t3chguy. * Fix call permissions check confusion around element call ([#30521](element-hq/element-web#30521)). Contributed by @t3chguy. * Fix line wrap around emoji verification ([#30523](element-hq/element-web#30523)). Contributed by @t3chguy. * Don't highlight redacted events ([#30519](element-hq/element-web#30519)). Contributed by @t3chguy. * Fix matrix.to links not being handled in the app ([#30522](element-hq/element-web#30522)). Contributed by @t3chguy. * Fix issue of new room list taking up the full width ([#30459](element-hq/element-web#30459)). Contributed by @langleyd. * Fix widget persistence in React development mode ([#30509](element-hq/element-web#30509)). Contributed by @robintown. * Fix widget initialization in React development mode ([#30463](element-hq/element-web#30463)). Contributed by @robintown. Changes in [1.11.109](https://github.com/element-hq/element-web/releases/tag/v1.11.109) (2025-08-11) ==================================================================================================== This release supports the upcoming v12 ("hydra") Matrix room version and is necessary to view and participate in these rooms. * [Backport staging] Allow /upgraderoom command without developer mode enabled ([#30529](element-hq/element-web#30529)). Contributed by @RiotRobot. * [Backport staging] Support for creator/owner power level ([#30526](element-hq/element-web#30526)). Contributed by @RiotRobot. * New room list: change icon and label of menu item for to start a DM ([#30470](element-hq/element-web#30470)). Contributed by @florianduros. * Implement the member list with virtuoso ([#29869](element-hq/element-web#29869)). Contributed by @langleyd. * Add labs option for history sharing on invite ([#30313](element-hq/element-web#30313)). Contributed by @richvdh. * Bump wysiwyg to 2.39.0 adding support for pasting rich text content in the Rich Text Edtior ([#30421](element-hq/element-web#30421)). Contributed by @langleyd. * Support `EventShieldReason.MISMATCHED_SENDER` ([#30403](element-hq/element-web#30403)). Contributed by @richvdh. * Change unencrypted and public pills to blue ([#30399](element-hq/element-web#30399)). Contributed by @florianduros. * Change color of public room icon ([#30390](element-hq/element-web#30390)). Contributed by @florianduros. * Script for updating storybook screenshots ([#30340](element-hq/element-web#30340)). Contributed by @dbkr. * Add toggle to hide empty state in devtools ([#30352](element-hq/element-web#30352)). Contributed by @toger5. * [Backport staging] Use userId to filter users in non-federated rooms when showing the InviteDialog ([#30537](element-hq/element-web#30537)). Contributed by @RiotRobot. * [Backport staging] Catch error when encountering invalid m.room.pinned\_events event ([#30536](element-hq/element-web#30536)). Contributed by @RiotRobot. * Update for compatibility with v12 rooms ([#30452](element-hq/element-web#30452)). Contributed by @dbkr. * New room list: fix tooltip on presence ([#30474](element-hq/element-web#30474)). Contributed by @florianduros. * New room list: add tooltip for presence and room status ([#30472](element-hq/element-web#30472)). Contributed by @florianduros. * Fix: Clicking on an item in the member list causes it to scroll to the top rather than show the profile view ([#30455](element-hq/element-web#30455)). Contributed by @langleyd. * Put the 'decrypting' tooltip back ([#30446](element-hq/element-web#30446)). Contributed by @dbkr. * Use server name explicitly for via. ([#30362](element-hq/element-web#30362)). Contributed by @Half-Shot. * fix: replace hardcoded string in poll history dialog ([#30402](element-hq/element-web#30402)). Contributed by @florianduros. * fix: replace hardcoded string on qr code back button ([#30401](element-hq/element-web#30401)). Contributed by @florianduros. * Fix color of icon button with outline ([#30361](element-hq/element-web#30361)). Contributed by @florianduros. Changes in [1.11.108](https://github.com/element-hq/element-web/releases/tag/v1.11.108) (2025-07-30) ==================================================================================================== * [Backport staging] Fix downloaded attachments not being decrypted ([#30434](element-hq/element-web#30434)). Contributed by @RiotRobot. Changes in [1.11.107](https://github.com/element-hq/element-web/releases/tag/v1.11.107) (2025-07-29) ==================================================================================================== * Message preview should show tooltip with the full message on hover ([#30265](element-hq/element-web#30265)). Contributed by @MidhunSureshR. * Support rendering notification badges on platforms that do their own icon overlays ([#30315](element-hq/element-web#30315)). Contributed by @Half-Shot. * Add SubscriptionViewModel base class ([#30297](element-hq/element-web#30297)). Contributed by @dbkr. * Enhancement: Save image on CTRL+S ([#30330](element-hq/element-web#30330)). Contributed by @ioalexander. * Add quote functionality to MessageContextMenu (#29893) ([#30323](element-hq/element-web#30323)). Contributed by @AlirezaMrtz. * Initial structure for shared component views ([#30216](element-hq/element-web#30216)). Contributed by @dbkr. * [Backport staging] Fix e2e shield being invisible in white mode for encrypted room ([#30411](element-hq/element-web#30411)). Contributed by @RiotRobot. * Force ED titlebar color for new room list ([#30332](element-hq/element-web#30332)). Contributed by @florianduros. * Add a background color to left panel for macos titlebar in element desktop ([#30328](element-hq/element-web#30328)). Contributed by @florianduros. * Fix: Prevent page refresh on Enter key in right panel member search ([#30312](element-hq/element-web#30312)). Contributed by @AlirezaMrtz.

…ncrypted rooms (element-hq#30440) * Show a blue lock instead of a grey shield for unencrypted rooms * Update screenshots and snapshot * Update snapshots and fix e2e test that used to expect the grey shield * lint and add tests for shield * Update more screen shots * finish unit test for left icon * Remove unneeded check * Don't bother adding stray props to E2EIcon for data-testid * Upate snapshots

Show a blue lock instead of a grey shield for unencrypted rooms

1424c00

langleyd added X-Blocked T-Enhancement labels Jul 30, 2025

langleyd changed the title ~~WIP: Show a blue lock instead of a grey shield for unencrypted rooms~~ WIP: Show a blue lock for unencrypted rooms and hide the grey shield for encrypted rooms Jul 30, 2025

github-actions bot deployed to Netlify July 30, 2025 17:57 View deployment

github-actions bot deployed to EndToEndTests July 30, 2025 18:17 View deployment

Merge branch 'develop' into langleyd/update_composer_encrpytion_icon

611fb97

github-actions bot deployed to Netlify July 31, 2025 13:40 View deployment

github-actions bot deployed to EndToEndTests July 31, 2025 13:56 View deployment

Update screenshots and snapshot

c14dd4b

github-actions bot deployed to Netlify July 31, 2025 16:41 View deployment

github-actions bot deployed to EndToEndTests July 31, 2025 16:53 View deployment

langleyd added 3 commits August 7, 2025 13:13

Merge branch 'develop' of github.com:vector-im/element-web into langl…

503a20a

…eyd/update_composer_encrpytion_icon

Merge branch 'develop' of github.com:vector-im/element-web into langl…

a73c8f4

…eyd/update_composer_encrpytion_icon

Update snapshots and fix e2e test that used to expect the grey shield

8b2fb8d

github-actions bot deployed to Netlify August 8, 2025 08:28 View deployment

github-actions bot deployed to EndToEndTests August 8, 2025 08:41 View deployment

langleyd added 2 commits August 8, 2025 10:08

lint and add tests for shield

2fcad9f

Update more screen shots

0ac912a

github-actions bot deployed to Netlify August 8, 2025 09:22 View deployment

github-actions bot deployed to EndToEndTests August 8, 2025 09:32 View deployment

langleyd and others added 2 commits August 8, 2025 10:42

finish unit test for left icon

6ae8649

Merge branch 'develop' into langleyd/update_composer_encrpytion_icon

8ecd9fe

langleyd removed the X-Blocked label Aug 8, 2025

github-actions bot deployed to Netlify August 8, 2025 09:46 View deployment

github-actions bot deployed to EndToEndTests August 8, 2025 09:57 View deployment

langleyd marked this pull request as ready for review August 8, 2025 10:01

langleyd requested review from a team as code owners August 8, 2025 10:01

langleyd requested a review from andybalaam August 8, 2025 10:01

langleyd changed the title ~~WIP: Show a blue lock for unencrypted rooms and hide the grey shield for encrypted rooms~~ Show a blue lock for unencrypted rooms and hide the grey shield for encrypted rooms Aug 8, 2025

t3chguy reviewed Aug 8, 2025

View reviewed changes

langleyd added 2 commits August 8, 2025 11:14

Remove unneeded check

db1bb65

Merge branch 'langleyd/update_composer_encrpytion_icon' of github.com…

0d1fe35

…:vector-im/element-web into langleyd/update_composer_encrpytion_icon

github-actions bot deployed to Netlify August 8, 2025 10:18 View deployment

github-actions bot deployed to EndToEndTests August 8, 2025 10:29 View deployment

Don't bother adding stray props to E2EIcon for data-testid

3575fa6

github-actions bot deployed to Netlify August 8, 2025 10:46 View deployment

github-actions bot deployed to EndToEndTests August 8, 2025 10:57 View deployment

andybalaam approved these changes Aug 8, 2025

View reviewed changes

Upate snapshots

1189f99

github-actions bot deployed to Netlify August 8, 2025 11:35 View deployment

github-actions bot deployed to EndToEndTests August 8, 2025 11:45 View deployment

langleyd requested a review from t3chguy August 8, 2025 11:55

t3chguy approved these changes Aug 11, 2025

View reviewed changes

langleyd added this pull request to the merge queue Aug 11, 2025

Merged via the queue into develop with commit 59531ea Aug 11, 2025
37 checks passed

langleyd deleted the langleyd/update_composer_encrpytion_icon branch August 11, 2025 10:06

langleyd mentioned this pull request Aug 20, 2025

Updates to composer decoration and room badges #29425

Closed

laxdragon mentioned this pull request Sep 3, 2025

private server with disabled e2ee element has "send an unencrypted message" on text input on all channels #30691

Closed

This was referenced Oct 6, 2025

New Element Web release v1.12.0 grueneschweiz/element-web-apache#1

Closed

New Element Web release v1.12.0 grueneschweiz/element-web-apache#2

Closed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Uh oh!

Show a blue lock for unencrypted rooms and hide the grey shield for encrypted rooms #30440

Show a blue lock for unencrypted rooms and hide the grey shield for encrypted rooms #30440

Uh oh!

langleyd commented Jul 30, 2025

Uh oh!

t3chguy Aug 8, 2025

Uh oh!

langleyd Aug 8, 2025

Uh oh!

t3chguy Aug 8, 2025

Uh oh!

t3chguy Aug 8, 2025

Uh oh!

Uh oh!

igorgterra commented Aug 27, 2025

Uh oh!

xfst14 commented Aug 28, 2025

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

6 participants

Uh oh!

Show a blue lock for unencrypted rooms and hide the grey shield for encrypted rooms #30440

Show a blue lock for unencrypted rooms and hide the grey shield for encrypted rooms #30440

Uh oh!

Conversation

langleyd commented Jul 30, 2025

Uh oh!

t3chguy Aug 8, 2025

Choose a reason for hiding this comment

Uh oh!

langleyd Aug 8, 2025

Choose a reason for hiding this comment

Uh oh!

t3chguy Aug 8, 2025

Choose a reason for hiding this comment

Uh oh!

t3chguy Aug 8, 2025

Choose a reason for hiding this comment

Uh oh!

Uh oh!

igorgterra commented Aug 27, 2025

Uh oh!

xfst14 commented Aug 28, 2025

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

6 participants