Hacky fix to the MatrixChat flakiness #30429
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add a sleep to let these tests clean up.
MidhunSureshR
approved these changes
Jul 30, 2025
Member
MidhunSureshR
left a comment
MidhunSureshR
left a comment
There was a problem hiding this comment.
Thanks for chasing this!
Would https://jestjs.io/docs/jest-object#jestrunalltimersasync help us in this context?
Member
Author
|
I think that only works if we're using fake timers (which these tests are not)? |
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
Member
|
If it does wait for all promises to resolve then IMO it's worth using fake timers just to prevent flakiness. |
Member
Author
|
I think that would probably necessitate more of a rewrite of these tests than I fancy right now. I'm going to merge this as-is, in the hope it improve things. |
Dileep9999
pushed a commit
to hemanth-nag/element-web
that referenced
this pull request
Oct 8, 2025
Add a sleep to let these tests clean up.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add a sleep to let these tests clean up.
Hopefully: fixes #30337, fixes #29708